Add support for Windows virtual keyboard#4515
Add support for Windows virtual keyboard#451510110111 wants to merge 1 commit intoStellarium:masterfrom
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
This adds support for calling osk.exe to get an on-screen keyboard whenever a QLineEdit, QComboBox or QDoubleComboBox are in focus, and closing the keyboard window when they are out of focus. This is not the normal keyboard provided by TabTip.exe, the Touch Keyboard and Handwriting Panel, but instead the Accessibility On-Screen Keyboard. While the normal keyboard may be possible to use, the method (https://superuser.com/a/1742459) is undocumented and may break in newer Windows versions, including by crashing the app implementing it (because of relying on a particular undocumented ABI). So this change doesn't do this. Fixes Stellarium#4478
c53aa85 to
4fc37ac
Compare
|
Just tried.
Does anybody really need it? Or is it technical debt that just has to be maintained for the sake of it? As found in #4478 the operating system's virtual keyboard does work after all. |
As long as the focus is in the input field, the keyboard stays. All as expected.
I'm not really sure. Since even the OP of the issue says that the solution without this PR is sufficient, I don't think we need this anymore. (And a downside of this accessibility keyboard is that it's slower than the normal one.) |
The panel is configured to vanish after search. So, the dialog is hidden, just the keyboard covers 1/3 of tablet screen. Testing this on my big screen, I have not checked how this appears on the small notebook. Maybe the kbd even covers the dialog? If you also are in doubt, I agree to close it. |
Description
This adds support for calling
osk.exeto get an on-screen keyboard whenever aQLineEdit,QComboBoxorQDoubleComboBoxare in focus, and closing the keyboard window when they are out of focus. This is not the normal keyboard provided byTabTip.exe, the Touch Keyboard and Handwriting Panel, but instead the Accessibility On-Screen Keyboard.While the normal keyboard may be possible to use, the method is undocumented and may break in newer Windows versions, including by crashing the app implementing it (because of relying on a particular undocumented ABI). So this PR doesn't do this.
Fixes #4478
Screenshots
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: