Skip to content

SCM Plugin: bug fixes#4557

Merged
alex-w merged 3 commits intoStellarium:masterfrom
xLPMG:scm-bugfixes
Oct 2, 2025
Merged

SCM Plugin: bug fixes#4557
alex-w merged 3 commits intoStellarium:masterfrom
xLPMG:scm-bugfixes

Conversation

@xLPMG
Copy link
Contributor

@xLPMG xLPMG commented Oct 1, 2025

While using the plugin, I have noticed a few small things that did not seem to work as intended. Instead of creating separate issues for each bug, I decided to fix them in one batch. Specifically:

  • Fix: Drawn constellations are not reset after "Export and Exit"
  • Fix: Stop drawing line key (Double Right Click) only works when Star/DSO is selected
  • Fix: Not all SC description input fields that are marked required are actually checked
  • Fix: No formal checks for 'Constellations' input field in SC description

For reasons of transparency, I have also updated the changelog. I suppose version 1.0.1 of the plugin will contain all changes up to the 25.4 release.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Manual tests.

Test Configuration:

  • Operating system: MacOS 26.0.1
  • Graphics Card: Apple M3 Pro

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to the 25.4 milestone Oct 2, 2025
@alex-w alex-w added the subsystem: plugins The issue is related to plugins of planetarium... label Oct 2, 2025
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit 4b50695 into Stellarium:master Oct 2, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Plugin: Sky Culture Maker Oct 2, 2025
@xLPMG xLPMG deleted the scm-bugfixes branch October 2, 2025 18:04
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Hello @xLPMG!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 29, 2025
@github-actions
Copy link

Hello @xLPMG!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: plugins The issue is related to plugins of planetarium...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants