-
-
Notifications
You must be signed in to change notification settings - Fork 978
Fix build with Qt6.10 #4667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with Qt6.10 #4667
Conversation
|
The second patch is better, but not very accurate still… |
|
What else is missing? I thought about comparing Qt${QT_VERSION_MAJOR}_VERSION instead of Qt6_VERSION, but this seems clearer to me, and in the case of Qt5 it's also false as expected |
Not missing, but splitting option onto parts may be painful in future…
Comparing Qt${QT_VERSION_MAJOR}_VERSION is better, but you are right - Qt6_VERSION seems clearer here. In any way comments is needed here. |
|
Added comment |
This reverts commit e7fd3f3.
This reverts commit 59702a5.
|
Hello @DarthGandalf! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @DarthGandalf! Please check the latest stable version of Stellarium: |
https://bugs.gentoo.org/966288
Description
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: