Skip to content

SCM: Use artIntensity from ConstellationMgr #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gzotti merged 5 commits into from
Dec 6, 2025
Merged

SCM: Use artIntensity from ConstellationMgr #4682

gzotti merged 5 commits into from
Dec 6, 2025
+25 −3

Conversation

@xLPMG
Copy link
Contributor

@xLPMG xLPMG commented Dec 4, 2025 •
edited
Loading

Added a connection for artIntensity to ConstellationMgr::artIntensityChanged

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping
  • [ ]

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gzotti
gzotti reviewed Dec 4, 2025
View reviewed changes
@xLPMG xLPMG changed the title SCM: Use artIntensity from ConstellationMgr and add nullptr guards SCM: Use artIntensity from ConstellationMgr Dec 4, 2025
@alex-w alex-w added this to the 25.4 milestone Dec 5, 2025
@alex-w alex-w added the subsystem: plugins The issue is related to plugins of planetarium... label Dec 5, 2025
gzotti
gzotti approved these changes Dec 6, 2025
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK for me.

@gzotti gzotti merged commit e024f59 into Stellarium:master Dec 6, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Plugin: Sky Culture Maker Dec 6, 2025
@xLPMG xLPMG deleted the scm-art-intensity-connection branch December 6, 2025 14:34
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Hello @xLPMG!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Hello @xLPMG!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-w alex-w alex-w approved these changes

@10110111 10110111 10110111 approved these changes

@gzotti gzotti gzotti approved these changes

Assignees

@xLPMG xLPMG

Labels

subsystem: plugins The issue is related to plugins of planetarium...

Projects

Plugin: Sky Culture Maker
Status: Done

Milestone

25.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xLPMG @alex-w @10110111 @gzotti