Skip to content

Conversation

@10110111
Copy link
Contributor

@10110111 10110111 commented Dec 6, 2025

Description

Now users will edit an actual list of references: a QTreeWidget, not having to deal with the Markdown syntax we use. This way we'll hopefully get a higher rate of syntactically correct SCs in new PRs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from alex-w and gzotti December 6, 2025 17:29
@alex-w alex-w added the subsystem: plugins The issue is related to plugins of planetarium... label Dec 6, 2025
@alex-w alex-w added this to the 25.4 milestone Dec 6, 2025
Now users will edit an actual list of references: a QTreeWidget, not
having to deal with the Markdown syntax we use.
@10110111 10110111 force-pushed the scm-better-references branch from d4673b7 to 2bc2e4f Compare December 6, 2025 17:38
@alex-w alex-w merged commit 24ea572 into master Dec 6, 2025
27 of 29 checks passed
@alex-w alex-w deleted the scm-better-references branch December 6, 2025 21:17
@github-project-automation github-project-automation bot moved this from Backlog to Done in Plugin: Sky Culture Maker Dec 6, 2025
@xLPMG
Copy link
Contributor

xLPMG commented Dec 6, 2025

My changes generate no new warnings

Hm on my system they do: (although very minor, but the goal should be no warnings :) )

SkyCultureMaker/src/gui/ScmSkyCultureDialog.cpp:40:33: warning: unused parameter 'parent' [-Wunused-parameter]
   40 |         QWidget* createEditor(QWidget* parent, const QStyleOptionViewItem& option, const QModelIndex& index) const 
SkyCultureMaker/src/gui/ScmSkyCultureDialog.cpp:40:69: warning: unused parameter 'option' [-Wunused-parameter]
   40 |         QWidget* createEditor(QWidget* parent, const QStyleOptionViewItem& option, const QModelIndex& index) const 
SkyCultureMaker/src/gui/ScmSkyCultureDialog.cpp:40:96: warning: unused parameter 'index' [-Wunused-parameter]
   40 |         QWidget* createEditor(QWidget* parent, const QStyleOptionViewItem& option, const QModelIndex& index) const

I'm not sure if this is a good practice, but one way to get rid of this is to not name the parameters:

QWidget* createEditor(QWidget*, const QStyleOptionViewItem&, const QModelIndex&) const override

@gzotti
Copy link
Member

gzotti commented Dec 6, 2025

You can use Q_UNUSED(param_not_used_elsewhere_in_body) to make it clearer.

@10110111
Copy link
Contributor Author

10110111 commented Dec 7, 2025

Hm on my system they do

Fixed in f180b2a.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 29, 2025
@github-actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: plugins The issue is related to plugins of planetarium...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants