Skip to content

Conversation

@MaraJadeLives
Copy link
Contributor

@MaraJadeLives MaraJadeLives commented Dec 29, 2025

Description

Trying to add the name of Calvera's supernova remnant. I'm not sure if @alex-w added all of the SNRs and candidates to catalog.dat (I didn't verify by ctrl-f-ing catalog.txt), but this one is an especially unusual SNR because of how far off-plane it is.
Source is the discovery paper or could use a later paper on the target.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

No tests, just copied the format for other SNRs and added this SNR as my first PR for this project.

Test Configuration:
N/A

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Trying to add the name of Calvera's supernova remnant
@alex-w alex-w merged commit c89ca85 into Stellarium:master Dec 29, 2025
4 of 5 checks passed
@alex-w alex-w added this to the 25.4 milestone Dec 29, 2025
@alex-w alex-w added this to Catalogs Dec 29, 2025
@github-project-automation github-project-automation bot moved this to Done in Catalogs Dec 29, 2025
@alex-w alex-w added the subsystem: catalogs The issue is related to supported catalogs of planetarium... label Dec 29, 2025
@alex-w
Copy link
Member

alex-w commented Dec 29, 2025

Thanks for contribution. By the fact I've not added SNR candidates into the joined catalog of DSO. Should we add SNR candidates into DSO catalog for version 26.1?

@gzotti
Copy link
Member

gzotti commented Dec 29, 2025

Where are they stored now?

@alex-w
Copy link
Member

alex-w commented Dec 29, 2025

Where are they stored now?

See attached files and links in #4634

@gzotti
Copy link
Member

gzotti commented Dec 29, 2025

IIRC there is a separate color for SNR candidates, so they should also be in the catalog.

@MaraJadeLives
Copy link
Contributor Author

MaraJadeLives commented Dec 29, 2025 via email

@alex-w
Copy link
Member

alex-w commented Dec 29, 2025

While the Calvera SNR is officially a candidate, there's been multiple papers that support it as a SNR. Also, the guy behind the catalog has retired and IDK if there will be future updates. Can the Calvera be added to SNRs? I would also appreciate adding SNR candidates to Stellarium for 26.1.

Is it possible to provide a machine-readable catalog for SNR candidates, similar to SNR catalog?

@alex-w
Copy link
Member

alex-w commented Dec 29, 2025

Short feature request is #4712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: catalogs The issue is related to supported catalogs of planetarium...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants