Include String type in panic payload casting
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxded
approved these changes
Jan 5, 2026
We know from experience - [and the `payload()` docs] - that the returned payload can be a `&'static str` or `String`, but we only downcast the former meaning that any owned (typically because of being `Debug`-formatted) error messages are not included in the panic log. Add the cast to include them. Note that Rust 1.91, slightly more than 2 months old at the time of writing added this cast to the `PanicHookInfo` type directly: https://doc.rust-lang.org/stable/std/panic/struct.PanicHookInfo.html#method.payload_as_str [and the `payload()` docs]: https://doc.rust-lang.org/stable/std/panic/struct.PanicHookInfo.html#method.payload
Set the `rust-version` in `Cargo.toml` for a multitude of reasons (crates.io shows it to users, and `cargo` can use it in its MSRV-aware resolver), including the `+nightly -Zminimal-versions generate-lockfile` step to generate a compatible `version = 3` `Cargo.lock` for MSRV 1.74 to consume, rather than `version = 4` which it doesn't understand yet.
Before that, the `log!` macro is not found inside `error!` expansion.
Because the `README` is _intentionally_ included as the root module/library documentation, its code sample is susceptible to `cargo tests` doctests.
…nt panic hook overwrites
MarijnS95
force-pushed
the
panic-include-string
branch
from
4d2f99e to
e3d42a9
Compare
MarijnS95
force-pushed
the
panic-include-string
branch
from
79d1dac to
1fab6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know from experience - and the
payload()docs - that the returned payload can be a&'static strorString, but we only downcast the former meaning that any owned (typically because of beingDebug-formatted) error messages are not included in the panic log. Add the cast to include them.Note that Rust 1.91 (slightly more than 2 months old at the time of writing) added this cast to the
PanicHookInfotype directly: https://doc.rust-lang.org/stable/std/panic/struct.PanicHookInfo.html#method.payload_as_str