Skip to content

Conversation

@meylis1998
Copy link
Contributor

Summary

Updates iOS templates to use Apple's UIScene lifecycle, which will be mandatory for all UIKit apps built with iOS 26+ SDK.

This PR adds:

  • iOS build CI workflow to verify UIScene configuration on template changes
  • Documentation updates with iOS Requirements section
  • CHANGELOG entry

Dependencies

⚠️ This is a draft PR - waiting for template updates to be merged and published.

Changes

File Description
.github/workflows/ios_build.yaml New CI workflow for iOS build verification
site/docs/templates/core.md Added iOS Requirements section
CHANGELOG.md Added feature entry

Requirements

  • Flutter: 3.38.0+
  • Xcode: 15.0+

References

Test plan

  • Verify iOS build workflow runs successfully
  • Verify documentation renders correctly
  • After bundle regeneration:
    • very_good create flutter_app test_app generates UIScene-enabled project
    • flutter build ios --no-codesign succeeds
    • App launches in iOS Simulator

- Add iOS build CI workflow to verify UIScene configuration
- Update documentation with iOS Requirements section
- Update CHANGELOG

Requires updated template bundles from BrickHub after
VeryGoodOpenSource/very_good_templates#416 is merged.

Closes VeryGoodOpenSource#1436
Regenerated bundles from local very_good_templates with UIScene lifecycle:
- very_good_core_bundle.dart
- very_good_flame_game_bundle.dart
- very_good_flutter_plugin_bundle.dart
@meylis1998 meylis1998 marked this pull request as ready for review December 29, 2025 20:33
@meylis1998 meylis1998 requested a review from a team as a code owner December 29, 2025 20:33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is auto generated by CI too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs shouldn't have references to migrations, that will be generated in the changelog when we merge the PR

@marcossevilla
Copy link
Member

@meylis1998 I think this PR should be closed since most changes will be generated and the ones that are not generated don't belong here

@meylis1998
Copy link
Contributor Author

After reviewing the feedback and investigating the codebase structure, I agree this PR should be closed. Here's why:

Why This PR Should Be Closed:

  1. The bundle files are auto-generated

    • All three changed bundle files (very_good_core_bundle.dart, very_good_flame_game_bundle.dart, very_good_flutter_plugin_bundle.dart) have // GENERATED CODE - DO NOT MODIFY BY HAND headers
    • They're generated by tool/generate_bundles.sh which runs mason bundle --source hosted
  2. The actual templates live in a separate repository

  3. Correct workflow:

    • Submit iOS UIScene lifecycle changes to the very_good_templates repository
    • After templates are updated and published to Mason registry, maintainers regenerate bundles in this repo

Next Steps:

Please open a PR in the very_good_templates repository with the iOS UIScene lifecycle changes and a video demo showing it working properly.

Thank you for your contribution! 🙏

@meylis1998 meylis1998 closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: update iOS template to use UIScene lifecycle for Flutter 3.38+

2 participants