-
Notifications
You must be signed in to change notification settings - Fork 229
feat: update iOS templates to use UIScene lifecycle #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update iOS templates to use UIScene lifecycle #1445
Conversation
- Add iOS build CI workflow to verify UIScene configuration - Update documentation with iOS Requirements section - Update CHANGELOG Requires updated template bundles from BrickHub after VeryGoodOpenSource/very_good_templates#416 is merged. Closes VeryGoodOpenSource#1436
Regenerated bundles from local very_good_templates with UIScene lifecycle: - very_good_core_bundle.dart - very_good_flame_game_bundle.dart - very_good_flutter_plugin_bundle.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog is auto generated by CI too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs shouldn't have references to migrations, that will be generated in the changelog when we merge the PR
|
@meylis1998 I think this PR should be closed since most changes will be generated and the ones that are not generated don't belong here |
|
After reviewing the feedback and investigating the codebase structure, I agree this PR should be closed. Here's why: Why This PR Should Be Closed:
Next Steps:Please open a PR in the very_good_templates repository with the iOS UIScene lifecycle changes and a video demo showing it working properly. Thank you for your contribution! 🙏 |
Summary
Updates iOS templates to use Apple's UIScene lifecycle, which will be mandatory for all UIKit apps built with iOS 26+ SDK.
This PR adds:
Dependencies
./tool/generate_bundles.shChanges
.github/workflows/ios_build.yamlsite/docs/templates/core.mdCHANGELOG.mdRequirements
References
Test plan
very_good create flutter_app test_appgenerates UIScene-enabled projectflutter build ios --no-codesignsucceeds