Use C-accelerated safe_load for YAML#4011
Merged
Conversation
PaaSTA is really just YAML all the way down, so using the pure Python functions here leads to a considerable slowdown - this change alone shaves ~20s off of setup_tron_namespace in one of our non-prod clusters e.g., the below are from a "noop" (i.e., no tron config changes to deploy) run of setup_tron_namespace: status quo: https://fluffy.yelpcorp.com/i/2tSjKC6btSV1RR8t3Z9FdBJrQrhRBPTR.svg this change: https://fluffy.yelpcorp.com/i/lMfLdcX1ZldCG8X1SNGQTB2Sg51fvldP.svg
nemacysts
requested review from
EmanElsaban,
EvanKrall,
KaspariK,
cuza and
jfongatyelp
jfongatyelp
previously approved these changes
Feb 26, 2025
cuza
previously approved these changes
Feb 26, 2025
EvanKrall
reviewed
Feb 27, 2025
ilkinmammadzada
previously approved these changes
Feb 27, 2025
Turns out that the way we do this in Tron is not exactly safe - so let's go back to a differently named file. That said, we can "shadow" `yaml` at import time with a well-placed `from ... import ... as yaml` :p
EvanKrall
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaaSTA is really just YAML all the way down, so using the pure Python
functions here leads to a considerable slowdown - this change alone
shaves ~20s off of setup_tron_namespace in one of our non-prod clusters
e.g., the below are from a "noop" (i.e., no tron config changes to
deploy) run of setup_tron_namespace:
status quo: https://fluffy.yelpcorp.com/i/2tSjKC6btSV1RR8t3Z9FdBJrQrhRBPTR.svg
this change: https://fluffy.yelpcorp.com/i/lMfLdcX1ZldCG8X1SNGQTB2Sg51fvldP.svg
(h/t to @Rob-Johnson for getting me to go down this rabbit-hole with his recent meshd change)