Add support for usetting pod identity with spark-run#4016
Conversation
930b83e to
4bbaaa0
Compare
|
whoops, meant to add this note to my review: @Qmando: probably wanna wait for someone on ml-compute to ship this as well since they own this, but lgtm :) |
Just to confirm - we're only getting the service accounts names here for executor pod identity, not creating them right? |
Yes, even currently you can only use SA that already exists on the namespace. This further filters it so that only IAM roles specified in yelpsoa-configs can be used. |
Co-authored-by: Luis Pérez <luisp@yelp.com>
|
@nemacysts @chi-yelp This change makes this PR much safer to deploy, but it also means we'll need to be more thorough with manual testing. I hope to deprecate it in the future when everything is setup correctly. |
As described in an internal tech spec document. Support for using pod identity for manual spark-runs.
Pairs with Yelp/service_configuration_lib#155
configure_and_run_docker_container, where they will be used for the driverTest run using spark integration test, as if iam_role set: https://fluffy.yelpcorp.com/i/mmcV6DNvz0zTbC6VJScBcFjKw3Dd466L.html
Test run with no iam_role set, --aws-credentials-yaml provided instead: https://fluffy.yelpcorp.com/i/WDm3kj0R3sg9rVqMkzMmzlJVpSSRhBNc.html
Test with unauthorized forced pod identity: https://fluffy.yelpcorp.com/i/XQR1VpgjCQXLfbd6CfJbdGkwGlKX4ZS5.html
Deployment plan:
If this gets merged, I'll update package version in dev and verify all the tron-based spark jobs are still succeeding as normal.