NOISSUE - Use SMQ for fML #117

JeffMboya · 2026-01-22T05:32:07Z

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

Use pickle for model2wasm Fix TinyGo entrypoint and m2cgen wrapping workflow Add FL task mode and metadata fields Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Include FL mode and spec in start payload Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add FL update envelope type for results Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Deduplicate FL helpers; update host and wazero Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Handle train results as FL envelope updates Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Coordinate federated rounds; validate and aggregate updates Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Coordinate federated rounds; validate and aggregate updates Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Coordinate federated rounds; validate and aggregate updates Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Coordinate federated rounds; validate and aggregate updates Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Make wazero StopApp idempotent like host Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Include numeric args in wazero WASI argv Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Update runtime and transport logic Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Fix CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

JeffMboya · 2026-01-22T05:33:44Z

JeffMboya · 2026-01-22T11:35:20Z

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

davidosodo · 2026-01-23T11:19:27Z

cli/fl.go

@@ -0,0 +1,100 @@
+package cli


Do we need this?

Since the FML is running as a demo application?

davidosodo · 2026-01-23T11:24:28Z

examples/fl-demo/coordinator-http/main.go

+	StartTime time.Time
+	Updates   []Update
+	Completed bool
+	mu        sync.Mutex


The RoundState struct has a mutex, but the map rounds that contains these states uses a separate roundsMu.

davidosodo · 2026-01-23T11:25:42Z

embed-proplet/src/mqtt_client.c

+  bool headers_complete = false;
+  size_t content_length = 0;
+
+  while (total_received < buffer_size - 1) {


When the HTTP headers span across multiple chunks, the code searches for "\r\n\r\n" only in the current chunk. If the header boundary falls across chunks, strstr() will fail to find it and headers_complete remains false indefinitely. Additionally, Content-Length parsing only happens in the chunk containing the headers.

davidosodo · 2026-01-23T11:40:40Z

embed-proplet/src/mqtt_client.c

+    }
+
+    if (results_len > 0) {
+      int ret = base64_encode((uint8_t *)update_b64, sizeof(update_b64), &encoded_len,


When base64 encoding fails, the code sets encoded_len = 0 and update_b64[0] = '\0' (via the else branch logic), but then continues to construct the JSON payload with empty update_b64 field. The coordinator will receive an update with no actual model update data, which should be treated as an error but is published as a successful update

davidosodo · 2026-01-23T11:41:14Z

pkg/fl/aggregator.go

+	return &FedAvgAggregator{}
+}
+
+func (f *FedAvgAggregator) Aggregate(updates []Update) (Model, error) {


totalSamples is declared as int, but update.NumSamples could be large. On 32-bit systems, int is typically 32 bits and can overflow if aggregating updates from many clients with large sample counts.

davidosodo · 2026-01-23T11:43:21Z

embed-proplet/src/mqtt_client.c

+  cJSON *fl_obj = cJSON_GetObjectItemCaseSensitive(json, "fl");
+  cJSON *env = cJSON_GetObjectItemCaseSensitive(json, "env");

  if (!cJSON_IsString(id) || !cJSON_IsString(name)) {


The code checks cJSON_IsString() which validates the item exists and is a string type, but doesn't verify that valuestring is non-NULL. In cJSON, even if an item is a string type, valuestring could theoretically be NULL in edge cases (though rare).

davidosodo · 2026-01-23T11:44:46Z

embed-proplet/src/mqtt_client.c

+    return;
+  }
+
+  if (t.is_fl_task && !t.is_fml_task && strlen(t.fl.job_id) == 0) {


The code has two separate FL detection mechanisms:

t.is_fl_task (set from JSON fl object)

t.is_fml_task (set from env ROUND_ID)
Issue: The two flags are checked inconsistently throughout the code. For example:

Line 665: if (t.is_fml_task && strlen(t.model_uri) > 0)

Line 693: else if (t.is_fl_task) // legacy

Line 754: if (t.is_fml_task && strlen(t.round_id) == 0) - this will reject FML tasks without ROUND_ID

Line 759: if (t.is_fl_task && !t.is_fml_task && strlen(t.fl.job_id) == 0) - rejects old FL tasks
This creates confusion about which FL protocol is being used and can cause valid tasks to be rejected.

davidosodo · 2026-01-23T11:45:30Z

pkg/fl/storage.go

+	ps.mu.RLock()
+	defer ps.mu.RUnlock()
+
+	roundFile := filepath.Join(ps.roundsDir, fmt.Sprintf("round_%s.json", roundID))


The roundID comes from user input (via HTTP requests or MQTT messages) and is directly used in file path construction. If roundID contains .. or absolute paths, it could write/read files outside the intended directory

davidosodo · 2026-01-23T11:46:15Z

manager/service.go


+func (svc *service) handleRoundStart(ctx context.Context) func(topic string, msg map[string]any) error {
+	return func(topic string, msg map[string]any) error {
+		go func() {


The goroutine spawned at line 498 doesn't check ctx.Done() and has no timeout mechanism. If the manager service shuts down, these goroutines will continue running indefinitely, attempting to access potentially closed resources (database connections, MQTT clients)

davidosodo · 2026-01-23T11:47:48Z

proplet/src/service.rs


+            let coordinator_url = env.get("COORDINATOR_URL")
+                .cloned()
+                .unwrap_or_else(|| "http://coordinator-http:8080".to_string());


Default service URLs are Docker Compose service names, which only work inside the demo Docker network. If services are deployed differently (Kubernetes, bare metal, different compose file), these hardcoded defaults fail.

Also let's use existing env parsing mechanism

JeffMboya added 30 commits January 22, 2026 08:30

Implemented a Federated Learning workflow for Propeller

5d05247

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add tests

a01c674

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add FL to embedded proplet

bdba774

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Address comments

e65b485

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Address comments

55fa201

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Address comments

6c6702b

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix CI

178678f

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refacftor: make manager workload agnostic

3b7abe5

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refacftor: replace http with mqtt

e3d208e

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add FML to embedded proplet

1dfb408

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Move docs file

e425361

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Updated client.c

ae3592c

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Address comments

0713664

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix unused import

d3ee30f

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix unused import

c552dc3

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix build errors

a5998de

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix build errors

da41e50

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add external wasmtime

5d8c1f6

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix missing envs

3ba38ff

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix FML round detection logic

5afca6d

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix result handling in coordinator

43f26c2

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix result handling in coordinator

3ef4f00

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add lazy loading to coordinator

fc01360

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix duplicate start command

2d5d845

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Enhance FML implementation

2425bb8

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove mqtt demo app; add http demo app

bbe40a8

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add proplet runtime as an HTTP proxy for WASM client

71ca7f7

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

JeffMboya added 20 commits January 22, 2026 08:30

Fix provisioning script

d4648eb

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix provisioning script

34c3396

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix provisioning script

8d67de1

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix provisioning script

f19407a

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Build manager and proplets locally

56b9400

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix Failed to connect to localhost port 7070

17c324c

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Update docs

6547efb

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix task initialization

7cee834

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix proplet identification

b43dde5

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix proplet ID mismatch

be027b0

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix OCI registry fetch

8c7758b

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Fix auth errors; Channel full, dropping container requests

dbc43cc

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Update docs

f54e204

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add local dataset

76f96f1

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused files

bc25214

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused files

e5d2111

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove duplicate envs

244b0c1

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Ignore env backup files

87e0798

Remove python test script

15f6a75

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Enhance docs

2a17f0c

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

JeffMboya mentioned this pull request Jan 22, 2026

PROP-96 - Add Federated ML to Propeller #97

Closed

Fix registry fetch

6c45a6e

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

JeffMboya mentioned this pull request Jan 22, 2026

NOISSUE - Add fml docs absmach/propeller-docs#20

Open

JeffMboya added 4 commits January 22, 2026 15:42

Fix markdown linter errors

88a59e2

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Clean up provisioned envs

2d883a1

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Enhance docs

1b8c51b

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Enhance docs

ebd12ef

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

davidosodo suggested changes Jan 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Use SMQ for fML #117

NOISSUE - Use SMQ for fML #117

Uh oh!

JeffMboya commented Jan 22, 2026

Uh oh!

JeffMboya commented Jan 22, 2026

Uh oh!

JeffMboya commented Jan 22, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

davidosodo Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NOISSUE - Use SMQ for fML #117

Are you sure you want to change the base?

NOISSUE - Use SMQ for fML #117

Uh oh!

Conversation

JeffMboya commented Jan 22, 2026

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

Uh oh!

JeffMboya commented Jan 22, 2026

Uh oh!

JeffMboya commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants