Skip to content

Conversation

@szjerrywang
Copy link

Describe what this PR does / why we need it

To support spring boot 3.5.0 and spring cloud 2025.0.0 dependencies.

Does this pull request fix one issue?

Describe how you did it

Update dependencies versions, fix some compilation errors.

Describe how to verify it

mvn install is done successfully.

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

<suppress files=".java" checks="AvoidStarImport" />
<suppress files=".java" checks="RegexpSinglelineJava" />
<suppress files=".*" checks="LineLength" />
</suppressions> No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<seata.version>2.3.0</seata.version>
<!-- Apache RocketMQ -->
<rocketmq.version>5.3.1</rocketmq.version>
<rocketmq.version>5.3.3</rocketmq.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, 在升级时有运行项目中的 example 例子吗?确保 example 正常运行且符合预期很有必要

}

@Override
public void fuzzyWatch(String groupNamePattern, FuzzyWatchEventWatcher listener) throws NacosException {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里文件的作用是什么?似乎它时一个空的 Mock 文件?

@@ -0,0 +1,62 @@
/*
* Copyright 2013-2023 the original author or authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版权年份应该是 2013-2025

import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpInputMessage;
import org.springframework.util.Assert;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了一个空行,下文也是

/**
* Using by {@link SentinelRestTemplate} and {@link SentinelProtectInterceptor}.
*
* @author <a href="mailto:[email protected]">Jim</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量不要删除这里的作者签名

}

@Override
public HttpHeaders getHeaders() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, 我看到这里是移到了 BaseHttpInputMessage 类中吗?

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jul 3, 2025

hi @szjerrywang 另外,我们有必要集成此 https://github.com/alibaba/spring-cloud-alibaba/pull/3929/files 变更吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants