-
Notifications
You must be signed in to change notification settings - Fork 8.5k
update spring boot, spring cloud, nacos client versions #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2023.x
Are you sure you want to change the base?
Conversation
yuluo-yx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
| <suppress files=".java" checks="AvoidStarImport" /> | ||
| <suppress files=".java" checks="RegexpSinglelineJava" /> | ||
| <suppress files=".*" checks="LineLength" /> | ||
| </suppressions> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <seata.version>2.3.0</seata.version> | ||
| <!-- Apache RocketMQ --> | ||
| <rocketmq.version>5.3.1</rocketmq.version> | ||
| <rocketmq.version>5.3.3</rocketmq.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, 在升级时有运行项目中的 example 例子吗?确保 example 正常运行且符合预期很有必要
| } | ||
|
|
||
| @Override | ||
| public void fuzzyWatch(String groupNamePattern, FuzzyWatchEventWatcher listener) throws NacosException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里文件的作用是什么?似乎它时一个空的 Mock 文件?
| @@ -0,0 +1,62 @@ | |||
| /* | |||
| * Copyright 2013-2023 the original author or authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
版权年份应该是 2013-2025
| import org.springframework.http.HttpHeaders; | ||
| import org.springframework.http.HttpInputMessage; | ||
| import org.springframework.util.Assert; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了一个空行,下文也是
| /** | ||
| * Using by {@link SentinelRestTemplate} and {@link SentinelProtectInterceptor}. | ||
| * | ||
| * @author <a href="mailto:[email protected]">Jim</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尽量不要删除这里的作者签名
| } | ||
|
|
||
| @Override | ||
| public HttpHeaders getHeaders() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, 我看到这里是移到了 BaseHttpInputMessage 类中吗?
|
hi @szjerrywang 另外,我们有必要集成此 https://github.com/alibaba/spring-cloud-alibaba/pull/3929/files 变更吗? |
Describe what this PR does / why we need it
To support spring boot 3.5.0 and spring cloud 2025.0.0 dependencies.
Does this pull request fix one issue?
Describe how you did it
Update dependencies versions, fix some compilation errors.
Describe how to verify it
mvn install is done successfully.
Special notes for reviews