fix(provider): remove inverted condition in convert_to_hashes#3609
Closed
aso20455 wants to merge 1 commit intoalloy-rs:mainfrom
Closed
fix(provider): remove inverted condition in convert_to_hashes#3609aso20455 wants to merge 1 commit intoalloy-rs:mainfrom
aso20455 wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
aso20455
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition
if block.transactions().is_empty()was inverted - it only converted to hashes when there were NO transactions, which is pointless. When the block actually had transactions, they were never converted.Removed the unnecessary check since
BlockTransactions::convert_to_hashes()already handles this internally by checkingif !self.is_hashes().