refactor(rpc-types-trace): remove unnecessary clone in test_selfdestruct_suicide #3629
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marukai67
requested review from
DaniPopes,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
reviewed
Feb 1, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but we can't accept PRs that only remove clones in test code - these provide no meaningful value to the project. We're looking for contributions that fix real bugs, add features, or improve production code performance.
Member
|
Closing - not accepting trivial test-only changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant .clone() call in the test_selfdestruct_suicide test when serializing TransactionTrace to JSON.