refactor: сentralize theme store, use .peek() to prevent infinite loops #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdvukhzhilov
changed the title
vdvukhzhilov
changed the title
vdvukhzhilov
force-pushed
the
theme-store-and-peek
branch
from
eff83af to
0f72429
Compare
vdvukhzhilov
force-pushed
the
theme-store-and-peek
branch
3 times, most recently
from
2a64804 to
6db7860
Compare
vdvukhzhilov
force-pushed
the
theme-store-and-peek
branch
from
6db7860 to
ff4c0d7
Compare
vdvukhzhilov
force-pushed
the
theme-store-and-peek
branch
from
069e904 to
fb77113
Compare
epszaw
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the application theme management system by centralizing it in the shared
web-commonspackage and fixing unwanted reactivity issues that could lead to infinite update cycles.Changes
.peek()Theme store improvements
The new theme store supports:
auto) - follows system preferenceslight/dark)Preact signals reactivity fix
@preact/signalsand@preact/signals-corein root package resolution, so that in every package it points to one version. This fixes when multiple instances of signals are used and reactivity is broken