Skip to content

Add @Valid annotation #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanil-shrestha wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add @Valid annotation #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...nexpress/synapse/api/rest/imperative/controller/BaseReadMonoImperativeRestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import io.swagger.v3.oas.annotations.responses.ApiResponses;
import jakarta.validation.Valid;
import org.springframework.http.HttpHeaders;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.PostMapping;
Expand Down Expand Up @@ -50,7 +51,7 @@ public abstract class BaseReadMonoImperativeRestController<
@ApiResponse(responseCode = "403", description = "Forbidden"),
})
@PostMapping(INQUIRY_RESULTS)
public ResponseEntity<O> read(@RequestHeader HttpHeaders headers, @RequestBody I serviceRequest) {
public ResponseEntity<O> read(@RequestHeader HttpHeaders headers, @RequestBody @Valid I serviceRequest) {
Copy link
Collaborator

@adgonz90 adgonz90 Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation was moved to Service level.
why is this coming up?

Copy link
Author

@sanil-shrestha sanil-shrestha Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image This is what we were getting when @Valid annotation was not there in controller

logger.entry(serviceRequest);

final O serviceResponse = service.execute(serviceRequest);
Expand Down