fix: strip shell comments from claude_args before parsing#803
Open
AlexanderBartash wants to merge 1 commit intoanthropics:mainfrom
Open
fix: strip shell comments from claude_args before parsing#803AlexanderBartash wants to merge 1 commit intoanthropics:mainfrom
AlexanderBartash wants to merge 1 commit intoanthropics:mainfrom
Conversation
The shell-quote library treats # as a comment character and swallows ALL content after it (including newlines), which causes later flags to be lost when users add comments to their claude_args. For example: ``` --model 'claude-haiku' # This is a comment --allowed-tools 'Edit' ``` Would result in `--allowed-tools` being swallowed into the comment object. This fix strips shell-style comment lines (lines starting with #) before passing to shell-quote for parsing. Fixes anthropics#802 #fix #vibe Co-authored-by: Claude <[email protected]>
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell-quotelibrary treating#as comment character, which swallows all subsequent content (including flags on new lines)stripShellComments()function to remove shell-style comment lines before parsingProblem
The
shell-quotelibrary treats#as a shell comment character. When users include comments in theirclaude_args:Everything after
#is swallowed into a comment object, causing--allowed-toolsto be lost.Evidence:
Solution
Strip shell-style comment lines (lines starting with optional whitespace +
#) before passing toshell-quote:Test plan
parse-sdk-options.test.tspassFixes #802