Skip to content

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 24, 2026
@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing local_store_meta_test (5537089) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=local_store_meta_test
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                             local_store_meta_test                  main
-----                                             ---------------------                  ----
arrow_reader_clickbench/async/Q1                  1.01      2.4±0.03ms        ? ?/sec    1.00      2.3±0.02ms        ? ?/sec
arrow_reader_clickbench/async/Q10                 1.05     11.5±0.48ms        ? ?/sec    1.00     11.0±0.25ms        ? ?/sec
arrow_reader_clickbench/async/Q11                 1.04     13.3±0.54ms        ? ?/sec    1.00     12.8±0.44ms        ? ?/sec
arrow_reader_clickbench/async/Q12                 1.01     22.5±0.46ms        ? ?/sec    1.00     22.3±0.54ms        ? ?/sec
arrow_reader_clickbench/async/Q13                 1.00     27.9±0.47ms        ? ?/sec    1.00     27.9±0.81ms        ? ?/sec
arrow_reader_clickbench/async/Q14                 1.01     25.2±0.52ms        ? ?/sec    1.00     24.9±1.03ms        ? ?/sec
arrow_reader_clickbench/async/Q19                 1.07      5.6±0.13ms        ? ?/sec    1.00      5.3±0.09ms        ? ?/sec
arrow_reader_clickbench/async/Q20                 1.00    113.8±0.65ms        ? ?/sec    1.14    130.0±1.48ms        ? ?/sec
arrow_reader_clickbench/async/Q21                 1.00    130.0±0.76ms        ? ?/sec    1.26    163.4±1.53ms        ? ?/sec
arrow_reader_clickbench/async/Q22                 1.00   262.5±12.43ms        ? ?/sec    1.18   308.6±23.74ms        ? ?/sec
arrow_reader_clickbench/async/Q23                 1.01    408.2±6.91ms        ? ?/sec    1.00    402.3±3.40ms        ? ?/sec
arrow_reader_clickbench/async/Q24                 1.03     30.9±0.48ms        ? ?/sec    1.00     29.9±1.00ms        ? ?/sec
arrow_reader_clickbench/async/Q27                 1.01     99.3±1.02ms        ? ?/sec    1.00     98.6±1.13ms        ? ?/sec
arrow_reader_clickbench/async/Q28                 1.01     96.7±0.80ms        ? ?/sec    1.00     95.8±1.57ms        ? ?/sec
arrow_reader_clickbench/async/Q30                 1.02     27.8±0.96ms        ? ?/sec    1.00     27.3±0.26ms        ? ?/sec
arrow_reader_clickbench/async/Q36                 1.01    108.8±1.58ms        ? ?/sec    1.00    107.6±0.80ms        ? ?/sec
arrow_reader_clickbench/async/Q37                 1.00     84.0±1.03ms        ? ?/sec    1.00     84.2±1.47ms        ? ?/sec
arrow_reader_clickbench/async/Q38                 1.00     33.2±0.43ms        ? ?/sec    1.01     33.5±0.48ms        ? ?/sec
arrow_reader_clickbench/async/Q39                 1.01     45.9±0.53ms        ? ?/sec    1.00     45.7±0.44ms        ? ?/sec
arrow_reader_clickbench/async/Q40                 1.01     28.0±0.50ms        ? ?/sec    1.00     27.7±0.43ms        ? ?/sec
arrow_reader_clickbench/async/Q41                 1.01     22.7±0.46ms        ? ?/sec    1.00     22.4±0.31ms        ? ?/sec
arrow_reader_clickbench/async/Q42                 1.01     10.9±0.15ms        ? ?/sec    1.00     10.8±0.12ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q1     1.00      2.3±0.02ms        ? ?/sec    1.00      2.3±0.03ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q10    1.02     10.7±0.44ms        ? ?/sec    1.00     10.4±0.23ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q11    1.04     12.5±0.47ms        ? ?/sec    1.00     12.0±0.26ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q12    1.02     21.8±0.48ms        ? ?/sec    1.00     21.4±0.31ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q13    1.01     26.7±0.55ms        ? ?/sec    1.00     26.4±0.62ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q14    1.03     24.4±0.43ms        ? ?/sec    1.00     23.7±0.29ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q19    1.04      5.1±0.13ms        ? ?/sec    1.00      4.9±0.07ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q20    1.13    123.7±1.14ms        ? ?/sec    1.00    109.8±0.98ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q21    1.11    138.3±0.84ms        ? ?/sec    1.00    125.1±1.22ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q22    1.12    257.5±2.24ms        ? ?/sec    1.00    229.0±1.81ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q23    1.13    393.8±3.04ms        ? ?/sec    1.00    349.0±3.31ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q24    1.06     30.6±0.61ms        ? ?/sec    1.00     28.8±0.40ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q27    1.02     95.6±0.65ms        ? ?/sec    1.00     94.2±1.08ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q28    1.02     93.4±0.76ms        ? ?/sec    1.00     91.8±0.59ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q30    1.04     26.9±0.64ms        ? ?/sec    1.00     25.9±0.64ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q36    1.02    104.0±1.20ms        ? ?/sec    1.00    102.5±1.05ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q37    1.01     80.6±0.79ms        ? ?/sec    1.00     79.9±0.54ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q38    1.04     30.4±0.64ms        ? ?/sec    1.00     29.2±0.35ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q39    1.05     42.2±0.63ms        ? ?/sec    1.00     40.2±1.08ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q40    1.09     27.3±0.71ms        ? ?/sec    1.00     25.1±0.80ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q41    1.07     21.5±0.48ms        ? ?/sec    1.00     20.1±0.19ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q42    1.02     10.4±0.21ms        ? ?/sec    1.00     10.2±0.22ms        ? ?/sec
arrow_reader_clickbench/sync/Q1                   1.00      2.0±0.02ms        ? ?/sec    1.00      2.0±0.02ms        ? ?/sec
arrow_reader_clickbench/sync/Q10                  1.00      7.9±0.29ms        ? ?/sec    1.00      7.9±0.14ms        ? ?/sec
arrow_reader_clickbench/sync/Q11                  1.00      9.5±0.15ms        ? ?/sec    1.00      9.5±0.09ms        ? ?/sec
arrow_reader_clickbench/sync/Q12                  1.20     34.5±1.36ms        ? ?/sec    1.00     28.8±0.55ms        ? ?/sec
arrow_reader_clickbench/sync/Q13                  1.00     41.8±2.83ms        ? ?/sec    1.04     43.6±1.22ms        ? ?/sec
arrow_reader_clickbench/sync/Q14                  1.03     32.0±0.67ms        ? ?/sec    1.00     31.2±0.51ms        ? ?/sec
arrow_reader_clickbench/sync/Q19                  1.03      4.4±0.06ms        ? ?/sec    1.00      4.2±0.08ms        ? ?/sec
arrow_reader_clickbench/sync/Q20                  1.00    177.6±1.49ms        ? ?/sec    1.00    177.3±1.95ms        ? ?/sec
arrow_reader_clickbench/sync/Q21                  1.00    225.5±2.10ms        ? ?/sec    1.04    233.5±1.99ms        ? ?/sec
arrow_reader_clickbench/sync/Q22                  1.00    476.0±3.51ms        ? ?/sec    1.00    477.7±4.58ms        ? ?/sec
arrow_reader_clickbench/sync/Q23                  1.00   427.9±14.18ms        ? ?/sec    1.01   433.1±21.20ms        ? ?/sec
arrow_reader_clickbench/sync/Q24                  1.06     41.7±0.54ms        ? ?/sec    1.00     39.2±0.66ms        ? ?/sec
arrow_reader_clickbench/sync/Q27                  1.01    156.0±1.29ms        ? ?/sec    1.00    153.8±1.16ms        ? ?/sec
arrow_reader_clickbench/sync/Q28                  1.00    147.9±1.39ms        ? ?/sec    1.00    147.3±1.63ms        ? ?/sec
arrow_reader_clickbench/sync/Q30                  1.00     28.1±0.85ms        ? ?/sec    1.00     28.1±0.49ms        ? ?/sec
arrow_reader_clickbench/sync/Q36                  1.01    155.3±1.66ms        ? ?/sec    1.00    154.1±2.55ms        ? ?/sec
arrow_reader_clickbench/sync/Q37                  1.02     88.0±1.20ms        ? ?/sec    1.00     86.1±1.09ms        ? ?/sec
arrow_reader_clickbench/sync/Q38                  1.02     29.4±0.54ms        ? ?/sec    1.00     28.7±0.37ms        ? ?/sec
arrow_reader_clickbench/sync/Q39                  1.02     34.3±0.55ms        ? ?/sec    1.00     33.8±0.56ms        ? ?/sec
arrow_reader_clickbench/sync/Q40                  1.02     26.3±0.43ms        ? ?/sec    1.00     25.9±0.58ms        ? ?/sec
arrow_reader_clickbench/sync/Q41                  1.01     28.7±0.51ms        ? ?/sec    1.00     28.4±0.26ms        ? ?/sec
arrow_reader_clickbench/sync/Q42                  1.00     12.4±0.20ms        ? ?/sec    1.00     12.3±0.12ms        ? ?/sec

@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing local_store_meta_test (5537089) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=local_store_meta_test
Results will be posted here when complete

@Dandandan
Copy link
Contributor Author

I think compared to File::open it should not be that much overhead - but anyway good to avoid syscalls.

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                             local_store_meta_test                  main
-----                                             ---------------------                  ----
arrow_reader_clickbench/async/Q1                  1.00      2.3±0.01ms        ? ?/sec    1.02      2.4±0.04ms        ? ?/sec
arrow_reader_clickbench/async/Q10                 1.00     10.3±0.20ms        ? ?/sec    1.01     10.5±0.18ms        ? ?/sec
arrow_reader_clickbench/async/Q11                 1.01     12.1±0.33ms        ? ?/sec    1.00     12.0±0.15ms        ? ?/sec
arrow_reader_clickbench/async/Q12                 1.00     21.2±0.33ms        ? ?/sec    1.01     21.4±0.30ms        ? ?/sec
arrow_reader_clickbench/async/Q13                 1.00     26.1±0.20ms        ? ?/sec    1.02     26.7±0.26ms        ? ?/sec
arrow_reader_clickbench/async/Q14                 1.00     23.7±0.37ms        ? ?/sec    1.01     24.1±0.32ms        ? ?/sec
arrow_reader_clickbench/async/Q19                 1.01      5.3±0.06ms        ? ?/sec    1.00      5.2±0.13ms        ? ?/sec
arrow_reader_clickbench/async/Q20                 1.00    113.3±0.97ms        ? ?/sec    1.26    143.3±1.43ms        ? ?/sec
arrow_reader_clickbench/async/Q21                 1.00    128.9±1.12ms        ? ?/sec    1.26    162.3±1.10ms        ? ?/sec
arrow_reader_clickbench/async/Q22                 1.14    266.2±6.91ms        ? ?/sec    1.00   234.1±15.47ms        ? ?/sec
arrow_reader_clickbench/async/Q23                 1.00    399.6±3.05ms        ? ?/sec    1.00    398.0±3.19ms        ? ?/sec
arrow_reader_clickbench/async/Q24                 1.01     29.7±0.32ms        ? ?/sec    1.00     29.6±0.23ms        ? ?/sec
arrow_reader_clickbench/async/Q27                 1.01     98.0±0.54ms        ? ?/sec    1.00     97.3±0.57ms        ? ?/sec
arrow_reader_clickbench/async/Q28                 1.01     95.2±0.58ms        ? ?/sec    1.00     94.2±0.77ms        ? ?/sec
arrow_reader_clickbench/async/Q30                 1.00     26.4±0.88ms        ? ?/sec    1.00     26.4±0.45ms        ? ?/sec
arrow_reader_clickbench/async/Q36                 1.01    106.9±0.72ms        ? ?/sec    1.00    106.0±0.79ms        ? ?/sec
arrow_reader_clickbench/async/Q37                 1.00     82.6±0.47ms        ? ?/sec    1.00     82.3±1.39ms        ? ?/sec
arrow_reader_clickbench/async/Q38                 1.01     31.9±0.22ms        ? ?/sec    1.00     31.6±0.43ms        ? ?/sec
arrow_reader_clickbench/async/Q39                 1.00     44.7±0.31ms        ? ?/sec    1.00     44.6±0.61ms        ? ?/sec
arrow_reader_clickbench/async/Q40                 1.00     26.4±0.31ms        ? ?/sec    1.00     26.3±0.49ms        ? ?/sec
arrow_reader_clickbench/async/Q41                 1.01     21.4±0.47ms        ? ?/sec    1.00     21.1±0.19ms        ? ?/sec
arrow_reader_clickbench/async/Q42                 1.00     10.7±0.13ms        ? ?/sec    1.00     10.7±0.12ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q1     1.00      2.3±0.05ms        ? ?/sec    1.01      2.3±0.04ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q10    1.00     10.0±0.20ms        ? ?/sec    1.01     10.0±0.11ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q11    1.00     11.5±0.20ms        ? ?/sec    1.01     11.5±0.16ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q12    1.00     20.5±0.32ms        ? ?/sec    1.00     20.5±0.39ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q13    1.00     25.2±0.38ms        ? ?/sec    1.00     25.3±0.42ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q14    1.00     22.9±0.27ms        ? ?/sec    1.00     22.8±0.28ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q19    1.02      5.0±0.12ms        ? ?/sec    1.00      4.9±0.04ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q20    1.13    123.1±1.79ms        ? ?/sec    1.00    109.2±0.78ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q21    1.10    137.3±0.85ms        ? ?/sec    1.00    124.3±1.05ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q22    1.12    252.0±1.45ms        ? ?/sec    1.00    225.6±1.92ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q23    1.12    385.8±3.22ms        ? ?/sec    1.00    346.0±2.72ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q24    1.05     29.3±0.61ms        ? ?/sec    1.00     28.1±0.24ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q27    1.01     94.7±0.62ms        ? ?/sec    1.00     93.8±0.55ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q28    1.01     91.7±1.24ms        ? ?/sec    1.00     91.0±0.70ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q30    1.02     25.8±0.27ms        ? ?/sec    1.00     25.3±0.26ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q36    1.01    103.3±0.91ms        ? ?/sec    1.00    102.2±0.68ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q37    1.01     80.1±1.59ms        ? ?/sec    1.00     79.3±0.54ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q38    1.03     29.3±0.46ms        ? ?/sec    1.00     28.5±0.39ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q39    1.03     40.4±0.85ms        ? ?/sec    1.00     39.2±0.37ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q40    1.04     25.8±0.78ms        ? ?/sec    1.00     24.8±0.26ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q41    1.03     20.5±0.19ms        ? ?/sec    1.00     19.9±0.25ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q42    1.01     10.3±0.11ms        ? ?/sec    1.00     10.1±0.03ms        ? ?/sec
arrow_reader_clickbench/sync/Q1                   1.00      2.1±0.06ms        ? ?/sec    1.00      2.0±0.03ms        ? ?/sec
arrow_reader_clickbench/sync/Q10                  1.00      7.7±0.12ms        ? ?/sec    1.00      7.7±0.07ms        ? ?/sec
arrow_reader_clickbench/sync/Q11                  1.00      9.3±0.05ms        ? ?/sec    1.01      9.3±0.07ms        ? ?/sec
arrow_reader_clickbench/sync/Q12                  1.18     32.8±1.24ms        ? ?/sec    1.00     27.8±0.71ms        ? ?/sec
arrow_reader_clickbench/sync/Q13                  1.00     39.4±2.65ms        ? ?/sec    1.06     41.7±1.52ms        ? ?/sec
arrow_reader_clickbench/sync/Q14                  1.01     30.3±0.47ms        ? ?/sec    1.00     29.9±0.45ms        ? ?/sec
arrow_reader_clickbench/sync/Q19                  1.02      4.2±0.02ms        ? ?/sec    1.00      4.1±0.02ms        ? ?/sec
arrow_reader_clickbench/sync/Q20                  1.01    175.2±1.34ms        ? ?/sec    1.00    174.2±1.02ms        ? ?/sec
arrow_reader_clickbench/sync/Q21                  1.00    222.1±2.18ms        ? ?/sec    1.04    230.9±1.25ms        ? ?/sec
arrow_reader_clickbench/sync/Q22                  1.00    466.6±3.62ms        ? ?/sec    1.01    470.1±3.22ms        ? ?/sec
arrow_reader_clickbench/sync/Q23                  1.00   419.0±13.59ms        ? ?/sec    1.03   430.7±19.32ms        ? ?/sec
arrow_reader_clickbench/sync/Q24                  1.00     38.9±0.35ms        ? ?/sec    1.00     38.9±0.28ms        ? ?/sec
arrow_reader_clickbench/sync/Q27                  1.00    151.3±1.60ms        ? ?/sec    1.00    150.9±1.48ms        ? ?/sec
arrow_reader_clickbench/sync/Q28                  1.00    144.0±1.28ms        ? ?/sec    1.00    143.4±1.11ms        ? ?/sec
arrow_reader_clickbench/sync/Q30                  1.00     26.5±0.69ms        ? ?/sec    1.01     26.8±0.30ms        ? ?/sec
arrow_reader_clickbench/sync/Q36                  1.00    150.3±1.08ms        ? ?/sec    1.00    149.8±1.03ms        ? ?/sec
arrow_reader_clickbench/sync/Q37                  1.01     85.4±1.29ms        ? ?/sec    1.00     84.5±1.28ms        ? ?/sec
arrow_reader_clickbench/sync/Q38                  1.01     28.4±0.52ms        ? ?/sec    1.00     28.1±0.49ms        ? ?/sec
arrow_reader_clickbench/sync/Q39                  1.01     32.7±0.67ms        ? ?/sec    1.00     32.5±0.45ms        ? ?/sec
arrow_reader_clickbench/sync/Q40                  1.00     25.3±0.50ms        ? ?/sec    1.00     25.4±0.24ms        ? ?/sec
arrow_reader_clickbench/sync/Q41                  1.00     27.9±0.33ms        ? ?/sec    1.00     27.9±0.18ms        ? ?/sec
arrow_reader_clickbench/sync/Q42                  1.00     12.2±0.22ms        ? ?/sec    1.00     12.2±0.14ms        ? ?/sec

@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing local_store_meta_test (a8b88c2) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=local_store_meta_test
Results will be posted here when complete

@alamb-ghbot
Copy link

Benchmark script failed with exit code 101.

Last 10 lines of output:

Click to expand

error[E0195]: lifetime parameters or bounds on method `copy_opts` do not match the trait declaration
   --> parquet/benches/arrow_reader_clickbench.rs:811:23
    |
811 |     async fn copy_opts(
    |                       ^ lifetimes do not match method in trait

Some errors have detailed explanations: E0195, E0432.
For more information about an error, try `rustc --explain E0195`.
error: could not compile `parquet` (bench "arrow_reader_clickbench") due to 7 previous errors

@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing local_store_meta_test (2effad3) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=local_store_meta_test
Results will be posted here when complete

@alamb-ghbot
Copy link

Benchmark script failed with exit code 101.

Last 10 lines of output:

Click to expand

error[E0195]: lifetime parameters or bounds on method `copy_opts` do not match the trait declaration
   --> parquet/benches/arrow_reader_clickbench.rs:818:23
    |
818 |     async fn copy_opts(
    |                       ^ lifetimes do not match method in trait

Some errors have detailed explanations: E0195, E0432.
For more information about an error, try `rustc --explain E0195`.
error: could not compile `parquet` (bench "arrow_reader_clickbench") due to 7 previous errors

@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing local_store_meta_test (a26df1a) to bd76edd diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=local_store_meta_test
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                             local_store_meta_test                  main
-----                                             ---------------------                  ----
arrow_reader_clickbench/async/Q1                  1.00      2.3±0.01ms        ? ?/sec    1.01      2.3±0.04ms        ? ?/sec
arrow_reader_clickbench/async/Q10                 1.00     10.6±0.23ms        ? ?/sec    1.01     10.7±0.27ms        ? ?/sec
arrow_reader_clickbench/async/Q11                 1.00     12.3±0.24ms        ? ?/sec    1.01     12.4±0.32ms        ? ?/sec
arrow_reader_clickbench/async/Q12                 1.00     21.9±0.21ms        ? ?/sec    1.01     22.0±0.26ms        ? ?/sec
arrow_reader_clickbench/async/Q13                 1.00     27.2±0.58ms        ? ?/sec    1.00     27.3±0.46ms        ? ?/sec
arrow_reader_clickbench/async/Q14                 1.00     24.4±0.33ms        ? ?/sec    1.01     24.6±0.29ms        ? ?/sec
arrow_reader_clickbench/async/Q19                 1.00      5.4±0.06ms        ? ?/sec    1.00      5.4±0.08ms        ? ?/sec
arrow_reader_clickbench/async/Q20                 1.00    115.1±1.32ms        ? ?/sec    1.13    130.5±0.95ms        ? ?/sec
arrow_reader_clickbench/async/Q21                 1.00    131.0±1.47ms        ? ?/sec    1.25    164.1±1.66ms        ? ?/sec
arrow_reader_clickbench/async/Q22                 1.00   261.2±11.77ms        ? ?/sec    1.14   296.9±36.54ms        ? ?/sec
arrow_reader_clickbench/async/Q23                 1.01    413.5±5.90ms        ? ?/sec    1.00    409.4±2.68ms        ? ?/sec
arrow_reader_clickbench/async/Q24                 1.00     30.6±0.47ms        ? ?/sec    1.01     30.8±0.78ms        ? ?/sec
arrow_reader_clickbench/async/Q27                 1.00     99.4±0.76ms        ? ?/sec    1.00     99.6±0.63ms        ? ?/sec
arrow_reader_clickbench/async/Q28                 1.00     97.0±1.78ms        ? ?/sec    1.00     97.1±0.75ms        ? ?/sec
arrow_reader_clickbench/async/Q30                 1.00     26.9±0.47ms        ? ?/sec    1.01     27.2±0.35ms        ? ?/sec
arrow_reader_clickbench/async/Q36                 1.00    108.3±0.68ms        ? ?/sec    1.00    108.6±0.70ms        ? ?/sec
arrow_reader_clickbench/async/Q37                 1.00     84.1±0.97ms        ? ?/sec    1.01     84.8±1.07ms        ? ?/sec
arrow_reader_clickbench/async/Q38                 1.00     32.6±0.57ms        ? ?/sec    1.01     32.7±0.57ms        ? ?/sec
arrow_reader_clickbench/async/Q39                 1.00     45.6±0.39ms        ? ?/sec    1.00     45.5±0.35ms        ? ?/sec
arrow_reader_clickbench/async/Q40                 1.00     27.8±0.42ms        ? ?/sec    1.00     27.7±0.91ms        ? ?/sec
arrow_reader_clickbench/async/Q41                 1.00     22.2±0.37ms        ? ?/sec    1.00     22.3±0.29ms        ? ?/sec
arrow_reader_clickbench/async/Q42                 1.00     10.7±0.13ms        ? ?/sec    1.01     10.9±0.21ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q1     1.00      2.3±0.01ms        ? ?/sec    1.01      2.3±0.02ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q10    1.00     10.3±0.25ms        ? ?/sec    1.00     10.3±0.14ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q11    1.00     11.8±0.41ms        ? ?/sec    1.01     11.9±0.24ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q12    1.01     21.3±0.56ms        ? ?/sec    1.00     21.2±0.32ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q13    1.00     26.2±0.88ms        ? ?/sec    1.01     26.5±0.42ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q14    1.00     23.8±0.31ms        ? ?/sec    1.00     23.8±0.27ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q19    1.00      5.2±0.04ms        ? ?/sec    1.00      5.2±0.10ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q20    1.03    114.1±0.70ms        ? ?/sec    1.00    110.6±0.80ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q21    1.03    130.2±0.68ms        ? ?/sec    1.00    125.9±0.67ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q22    1.03    237.0±1.53ms        ? ?/sec    1.00    230.4±1.52ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q23    1.00    355.4±2.40ms        ? ?/sec    1.04    369.7±2.07ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q24    1.01     29.6±0.53ms        ? ?/sec    1.00     29.3±0.36ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q27    1.04     98.7±0.69ms        ? ?/sec    1.00     95.1±0.53ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q28    1.04     96.7±0.58ms        ? ?/sec    1.00     92.8±1.06ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q30    1.02     26.4±0.41ms        ? ?/sec    1.00     25.8±0.19ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q36    1.04    107.4±0.82ms        ? ?/sec    1.00    103.4±0.72ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q37    1.03     84.0±0.82ms        ? ?/sec    1.00     81.2±0.97ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q38    1.10     32.3±0.81ms        ? ?/sec    1.00     29.3±0.63ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q39    1.12     44.7±0.37ms        ? ?/sec    1.00     40.0±0.37ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q40    1.01     25.8±0.28ms        ? ?/sec    1.00     25.6±0.36ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q41    1.00     20.7±0.27ms        ? ?/sec    1.00     20.6±0.29ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q42    1.00     10.3±0.12ms        ? ?/sec    1.00     10.3±0.09ms        ? ?/sec
arrow_reader_clickbench/sync/Q1                   1.00      2.0±0.01ms        ? ?/sec    1.00      2.0±0.02ms        ? ?/sec
arrow_reader_clickbench/sync/Q10                  1.00      7.7±0.04ms        ? ?/sec    1.01      7.8±0.08ms        ? ?/sec
arrow_reader_clickbench/sync/Q11                  1.00      9.3±0.18ms        ? ?/sec    1.01      9.4±0.07ms        ? ?/sec
arrow_reader_clickbench/sync/Q12                  1.17     33.4±1.37ms        ? ?/sec    1.00     28.4±0.68ms        ? ?/sec
arrow_reader_clickbench/sync/Q13                  1.00     40.4±2.51ms        ? ?/sec    1.03     41.8±1.02ms        ? ?/sec
arrow_reader_clickbench/sync/Q14                  1.02     30.8±0.75ms        ? ?/sec    1.00     30.3±0.25ms        ? ?/sec
arrow_reader_clickbench/sync/Q19                  1.00      4.3±0.11ms        ? ?/sec    1.00      4.3±0.04ms        ? ?/sec
arrow_reader_clickbench/sync/Q20                  1.00    177.0±1.01ms        ? ?/sec    1.00    177.1±1.66ms        ? ?/sec
arrow_reader_clickbench/sync/Q21                  1.00    225.2±2.04ms        ? ?/sec    1.04    233.8±2.08ms        ? ?/sec
arrow_reader_clickbench/sync/Q22                  1.00    477.0±3.22ms        ? ?/sec    1.00    475.8±3.70ms        ? ?/sec
arrow_reader_clickbench/sync/Q23                  1.00   428.8±15.02ms        ? ?/sec    1.02   436.7±21.10ms        ? ?/sec
arrow_reader_clickbench/sync/Q24                  1.06     40.2±0.38ms        ? ?/sec    1.00     38.0±0.42ms        ? ?/sec
arrow_reader_clickbench/sync/Q27                  1.00    153.7±1.50ms        ? ?/sec    1.00    153.0±1.48ms        ? ?/sec
arrow_reader_clickbench/sync/Q28                  1.00    146.6±1.36ms        ? ?/sec    1.00    146.8±1.33ms        ? ?/sec
arrow_reader_clickbench/sync/Q30                  1.00     27.4±0.74ms        ? ?/sec    1.00     27.4±0.36ms        ? ?/sec
arrow_reader_clickbench/sync/Q36                  1.00    153.0±1.71ms        ? ?/sec    1.00    152.6±1.11ms        ? ?/sec
arrow_reader_clickbench/sync/Q37                  1.00     86.8±0.56ms        ? ?/sec    1.00     86.7±0.69ms        ? ?/sec
arrow_reader_clickbench/sync/Q38                  1.00     28.7±0.70ms        ? ?/sec    1.01     29.0±0.27ms        ? ?/sec
arrow_reader_clickbench/sync/Q39                  1.00     33.2±0.42ms        ? ?/sec    1.02     33.8±0.39ms        ? ?/sec
arrow_reader_clickbench/sync/Q40                  1.00     25.9±0.23ms        ? ?/sec    1.01     26.1±0.37ms        ? ?/sec
arrow_reader_clickbench/sync/Q41                  1.00     28.5±0.37ms        ? ?/sec    1.01     28.7±0.27ms        ? ?/sec
arrow_reader_clickbench/sync/Q42                  1.00     12.2±0.09ms        ? ?/sec    1.01     12.3±0.07ms        ? ?/sec

@Dandandan
Copy link
Contributor Author

Interesting... doesn't seem like any impact at all on the benchmark machine but on my machine it does...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants