parquet: reader datapage v2 skip decoder set up if all values are nulls #9261
+53
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyang24
force-pushed
the
datapagev2_opt1
branch
5 times, most recently
from
16c49e0 to
dd6fd06
Compare
When a DataPageV2 has num_nulls == num_values, skip the values decoder setup since there are no actual values to decode. This avoids unnecessary work for all-null pages. Also add early returns for num_values == 0 in all ColumnValueDecoder implementations to safely handle the case when the decoder is called with zero values (which happens when all values are null).
lyang24
force-pushed
the
datapagev2_opt1
branch
from
dd6fd06 to
76cb873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
the Page Header of datapage v2 has num values and num nulls if all values are null we can skip setting up decoder.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
no