GH-48906: [C++] Optimize StructArray diffing with field by field comparison #48907
+136
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
optimize-struct-diff
branch
from
b1e041c to
54c6b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
StructArraydiffing was inefficient because it compared all fields together with no early termination. For a 10-field struct, even if the first field differs, it checks all 10 fields.What changes are included in this PR?
Introduced
StructValueComparatorthat compares struct fields independently with early termination.Are these changes tested?
Yes, added
DiffTest.StructFieldComparisonandDiffTest.NestedStructComparisonAll existing struct diff tests pass. Plus, I verified this with local benchmark (can be shared if asked).
Are there any user-facing changes?
No behavioral changes but optimization for
Array.diff().