Skip to content

Conversation

@killzoner
Copy link
Contributor

@killzoner killzoner commented Jan 9, 2026

Which issue does this PR close?

Closes #1189.
Revival of #1216 with added configuration.

Rationale for this change

Being able to make use of optimized Arrow IPC reads

What changes are included in this PR?

  • Added arrow-ipc-optimizations feature (default enabled) to enable option
  • Removed some unused workspace dependencies (running cargo neat)

Are there any user-facing changes?

No

Copy link
Contributor

@milenkovicm milenkovicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @killzoner
i think changes make sense.
My major comment for discussion if validation should be runtime configuration rather than compile time, I'm leaning towards later, but open for discussion

@killzoner
Copy link
Contributor Author

thanks @killzoner i think changes make sense. My major comment for discussion if validation should be runtime configuration rather than compile time, I'm leaning towards later, but open for discussion

I pretty much replicated existing config setup, but a compile time config makes sense, as it's a strong default not supposed to be changed frequently.

I will put this specific config under a new feature gate, part of the default features. If you have a name in mind don't hesitate 😄

@milenkovicm
Copy link
Contributor

Im bad with naming things 😁

@killzoner killzoner force-pushed the issue-1189 branch 3 times, most recently from ad0869e to 959248b Compare January 12, 2026 21:04
@killzoner killzoner force-pushed the issue-1189 branch 3 times, most recently from 104b58e to d54bbd3 Compare January 13, 2026 08:34
@killzoner
Copy link
Contributor Author

Removed all unecessary parametrization, moved config to ShuffleReaderExec. Also duplicated the function for config in FlightService, since i was not sure it made sense to refer to Ballista core config for FlightService config

Copy link
Contributor

@milenkovicm milenkovicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just two minor comments,

@milenkovicm
Copy link
Contributor

thanks @killzoner
i have just a minor comment, i think it makes sense.
will merge this once i kick ballista 51 release process

@killzoner
Copy link
Contributor Author

thanks @killzoner i have just a minor comment, i think it makes sense. will merge this once i kick ballista 51 release process

Thanks! Updated from your suggestions

@milenkovicm milenkovicm merged commit f30b81b into apache:main Jan 17, 2026
28 checks passed
@killzoner killzoner deleted the issue-1189 branch January 18, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using with_skip_validation for shuffle file reading

2 participants