Support different scales for decimal binary math functions #19874
+936
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce calculate_binary_math_decimal and calculate_binary_math_numeric functions with a proper handling of arguments of different scales and type casting. They supersede calculate_binary_math and calculate_binary_math_decimal due to having a slightly different functior signature with automatic passing of effective precision and scale (even if rescaled).
github-actions
bot
added
sqllogictest
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A helper
calculate_binary_math andUDFs relying on it could behave strangely if the scales of inputs and outputs are different. Original logic didn't fully handle it.So let's introduce
calculate_binary_math_decimalandcalculate_binary_math_numeric functionswith a proper handling of arguments of different scales and type casting for input and output arguments.They supersede
calculate_binary_mathandcalculate_binary_math_decimalbecause they have a slightly different functor signature that automatically passes the effective precision and scale (even if rescaled). The rest is compatible.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Older functions could be deprecated. Since they are a part of the public interface of datafusion-functions, I just placed a comment without a full-fledged
deprecatemacro. Up to discussion whether it should be used