HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

ramitg254 · 2026-01-07T13:00:42Z

…for Iceberg table

What changes were proposed in this pull request?

Adds support for using partition spec with describe statement for iceberg table.
and updated the other test outputs as partition information is also gettting printed for desc statement after the changes

Why are the changes needed?

currently using partition spec with describe statement for iceberg table result in unsupported exception

Does this PR introduce any user-facing change?

yes, this statement will not result in exception anymore

How was this patch tested?

build locally and ci tests and added q tests

…for Iceberg table

kokila-19 · 2026-01-13T19:25:30Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java

    return null;
  }
+
+  private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException {


The logic here is almost same as getPartition() in DescTableOperation.java https://github.com/apache/hive/pull/6259/changes#diff-641c62b42b01bff41c89a3b3661c15d6c08fce0e48740347f36fe32448984147R131

Check if you can add them in an utility so it can be reused

Thanks for checking it, moved out this logic from DescTableOperation.java and DescTableAnalyzer.java to HiveIcebergStorageHandler.java
https://github.com/apache/hive/pull/6259/changes#diff-93864ecf035fe51b92185015da842a56837cea89064813de39c278c6f8fed03cR2079
please take a look

soumyakanti3578

DDLUtils.isIcebergTable() has been used in many places in the compiler. I think we should not use a specific table type here.

soumyakanti3578 · 2026-01-13T23:30:26Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java

  }
+
+  private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException {
+    boolean isIcebergTable = DDLUtils.isIcebergTable(tab);


Please don't use DDLUtils.isIcebergTable as this API in the compiler is too specific. Instead please use tab.isNonNative() in conjunction to other APIs if needed.

Thanks for checking it, tried to make changes more generic to non native tables instead of iceberg centric please take a look

@ramitg254, consider joining with Table.hasNonNativePartitionSupport

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

deniskuzZ · 2026-01-19T17:51:14Z

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java

+    try {
+      List<String> partNames = getPartitionNames(icebergTable, partitionSpec, false);
+      return !partNames.isEmpty() &&
+              Warehouse.makePartName(partitionSpec, false).equals(partNames.getFirst());


do we really need
Warehouse.makePartName(partitionSpec, false).equals(partNames.getFirst())
check?
isn't !partNames.isEmpty() enough? we already pass the partitionSpec to getPartitionNames

But let's say for eg. for partspec is c=6 and parts available are c=6/d=hello6 only, then we would like to throw partition not found exception and that's why .equals is required as well

makes sense, but could we please do minor refactor and move the whole getPartition into IcebergTableUtil?

public static Partition getPartition(Configuration conf, org.apache.hadoop.hive.ql.metadata.Table table, Map<String, String> partitionSpec) throws SemanticException { List<String> partNames = getPartitionNames(conf, table, partitionSpec, false); if (partNames.isEmpty()) { return null; } try { String expectedName = Warehouse.makePartName(partitionSpec, false); if (!expectedName.equals(partNames.getFirst())) { return null; } return new DummyPartition(table, expectedName, partitionSpec); } catch (MetaException e) { throw new SemanticException("Unable to construct dummy partition", e); } } public static List<String> getPartitionNames(Configuration conf, org.apache.hadoop.hive.ql.metadata.Table table, Map<String, String> partSpecMap, boolean latestSpecOnly) throws SemanticException { Table icebergTable = getTable(conf, table.getTTable()); .... }

also please drop Boolean.TRUE.equals(latestSpecOnly) and Boolean.FALSE.equals(latestSpecOnly)

@ramitg254, please check this, i think that the only remaining

so either if we are moving it then hms table should be used as parameter
if you thing iceberg table as parameter for method to be used then moving it won't be good IMO

my bad, I saw some method have hms table as param as well, I'll update it

done, moved getPartition but kept hasPartition as it can have its idependent use case as well instead of keeping all of it in getPartition

please drop hasPartition, and use the snippet attached (i.e. it doesn't have any other usages).

Note, it requires getPartitionNames signature change as well to use Configuration conf, org.apache.hadoop.hive.ql.metadata.Table.

but it should have iceberg table as parameter instead of hms table

no, it shouldn't. hms table is just fine

IcebergTableUtil.getTable is duplicated in 2 caller methods, should be dropped.
Please check the complete snippet above

done, used the snippet just a change was needed in the snippet needed to move

List<String> partNames = getPartitionNames(conf, table, partitionSpec, false); if (partNames.isEmpty()) { return null; }

inside try block as well as it can throw :

Caused by: org.apache.hadoop.hive.ql.parse.SemanticException: No partition column by the name: pcol at org.apache.iceberg.mr.hive.IcebergTableUtil.generateExpressionFromPartitionSpec

from generateExpressionFromPartitionSpec in getPartitionNames when executedexplain insert queries so needed to catch that exception and return null as well

deniskuzZ · 2026-01-19T18:05:50Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java

-      List<FieldSchema> partitionColumns = table.isPartitioned() ? table.getPartCols() : null;
+      List<FieldSchema> partitionColumns = null;
+      if (table.isPartitioned()) {
+        partitionColumns = table.hasNonNativePartitionSupport() ?


not sure, but maybe we could move hasNonNativePartitionSupport logic inside of Table#getPartCols() , similar to

public List<String> getPartColNames() { List<FieldSchema> partCols = hasNonNativePartitionSupport() ? getStorageHandler().getPartitionKeys(this) : getPartCols(); return partCols.stream().map(FieldSchema::getName) .collect(Collectors.toList()); }

If you can check this - would be great, but i think there was some issue. we might handle this in the follow-up, just trying to avoid code duplication

yes actually my first approach was to do this only but there were issues regarding when statistics were computed after insertion resulting in index out of bound exception as that is dependent getPartCols but this is the only one known to me but there can be other scenarios where it is getting used and can cause issues so avoiding this for now.
and will tackle this code duplication once we have updated implementation of getPartCols with a follow up ticket

deniskuzZ · 2026-01-19T18:06:48Z

ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java

    List<String> values = new ArrayList<String>();
-    for (FieldSchema fs : this.getTable().getPartCols()) {
+    for (FieldSchema fs :
+            table.hasNonNativePartitionSupport() ?


same #6259 (comment)

deniskuzZ

LGTM, left minor comments

deniskuzZ · 2026-01-20T23:52:26Z

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java

    }
  }

+  public static boolean hasPartition(Table icebergTable,


please drop this, and use the snippet attached

done, dropped

sonarqubecloud · 2026-01-21T06:19:41Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asf-ci-hive added tests pending tests unstable and removed tests pending tests unstable labels Jan 7, 2026

ramitg254 force-pushed the HIVE-29376 branch from 562a7ae to b7c1df6 Compare January 8, 2026 16:56

asf-ci-hive added tests pending tests failed and removed tests unstable tests pending labels Jan 8, 2026

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported …

a8204f5

…for Iceberg table

ramitg254 force-pushed the HIVE-29376 branch from b7c1df6 to a8204f5 Compare January 8, 2026 17:21

asf-ci-hive added tests pending and removed tests failed labels Jan 8, 2026

ramitg254 changed the title ~~[WIP]HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported …~~ HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … Jan 8, 2026

asf-ci-hive added tests passed and removed tests pending labels Jan 8, 2026

addressed sonar issues

a32a9b8

asf-ci-hive added tests pending tests failed tests passed and removed tests passed tests pending tests failed labels Jan 9, 2026

kokila-19 reviewed Jan 13, 2026

View reviewed changes

soumyakanti3578 requested changes Jan 13, 2026

View reviewed changes

asf-ci-hive added tests pending tests passed and removed tests unstable tests pending labels Jan 16, 2026

deniskuzZ reviewed Jan 17, 2026

View reviewed changes

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java Outdated Show resolved Hide resolved

deniskuzZ reviewed Jan 17, 2026

View reviewed changes

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java Outdated Show resolved Hide resolved

moved partition presence method

3879868

asf-ci-hive added tests pending tests passed and removed tests passed tests pending labels Jan 18, 2026

deniskuzZ reviewed Jan 19, 2026

View reviewed changes

deniskuzZ reviewed Jan 20, 2026

View reviewed changes

refractor methods

db7a35c

asf-ci-hive added tests pending tests passed and removed tests passed tests pending labels Jan 20, 2026

deniskuzZ reviewed Jan 20, 2026

View reviewed changes

asf-ci-hive added tests pending tests failed and removed tests passed tests pending labels Jan 21, 2026

dropped hasPartition

e77fe17

ramitg254 force-pushed the HIVE-29376 branch from 0128b63 to e77fe17 Compare January 21, 2026 05:23

asf-ci-hive added tests pending and removed tests failed labels Jan 21, 2026

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

Are you sure you want to change the base?

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

Conversation

ramitg254 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soumyakanti3578 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

deniskuzZ Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ramitg254 Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deniskuzZ Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ramitg254 Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ramitg254 Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deniskuzZ Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ramitg254 Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deniskuzZ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate passed

Uh oh!

ramitg254 commented Jan 7, 2026 •

edited

Loading

deniskuzZ Jan 19, 2026 •

edited

Loading

ramitg254 Jan 19, 2026 •

edited

Loading

deniskuzZ Jan 20, 2026 •

edited

Loading

ramitg254 Jan 20, 2026 •

edited

Loading

ramitg254 Jan 20, 2026 •

edited

Loading

deniskuzZ Jan 20, 2026 •

edited

Loading

ramitg254 Jan 21, 2026 •

edited

Loading