Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 21, 2026

Why are the changes needed?

This PR enhances kyuubi.metrics.json.location to support variable substitution: {{KYUUBI_HOME}}, {{KYUUBI_WORK_DIR_ROOT}}, and changes the default value to {{KYUUBI_HOME}}/metrics - I suppose it is a more reasonable default value than {{KYUUBI_WORK_DIR_ROOT}}/metrics, given others dirs also under KYUUBI_HOME by default

export KYUUBI_LOG_DIR="${KYUUBI_LOG_DIR:-"${KYUUBI_HOME}/logs"}"
export KYUUBI_PID_DIR="${KYUUBI_PID_DIR:-"${KYUUBI_HOME}/pid"}"
export KYUUBI_WORK_DIR_ROOT="${KYUUBI_WORK_DIR_ROOT:-"${KYUUBI_HOME}/work"}"

To make things more consistent, variable substitution behavior is also updated for kyuubi.metadata.store.jdbc.url

How was this patch tested?

Manually tested by

bin/kyuubi run \
  --conf kyuubi.metrics.reporters=JSON \
  --conf kyuubi.metrics.json.location={{KYUUBI_HOME}}/metrics
bin/kyuubi run \
  --conf kyuubi.metrics.reporters=JSON \
  --conf kyuubi.metrics.json.location={{KYUUBI_WORK_DIR_ROOT}}/metrics

and checks the metrics JSON file.

Was this patch authored or co-authored using generative AI tooling?

No.

pan3793 and others added 2 commits January 21, 2026 17:14
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (69e8e95) to head (71e4b28).

Files with missing lines Patch % Lines
...ommon/src/main/scala/org/apache/kyuubi/Utils.scala 0.00% 12 Missing ⚠️
...i/server/metadata/jdbc/JDBCMetadataStoreConf.scala 0.00% 3 Missing ⚠️
...rg/apache/kyuubi/metrics/JsonReporterService.scala 0.00% 2 Missing ⚠️
.../scala/org/apache/kyuubi/metrics/MetricsConf.scala 0.00% 2 Missing ⚠️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 0.00% 2 Missing ⚠️
...rg/apache/kyuubi/zookeeper/EmbeddedZookeeper.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7310   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         698     698           
  Lines       43649   43654    +5     
  Branches     5894    5896    +2     
======================================
- Misses      43649   43654    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pan3793 , LGTM

@pan3793
Copy link
Member Author

pan3793 commented Jan 21, 2026

thanks, merging to master

@pan3793 pan3793 self-assigned this Jan 21, 2026
@pan3793 pan3793 added this to the v1.12.0 milestone Jan 21, 2026
@pan3793 pan3793 closed this in dfd9b49 Jan 21, 2026
@pan3793 pan3793 deleted the json-metrics branch January 22, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants