-
Notifications
You must be signed in to change notification settings - Fork 982
JSON metrics report path supports variables substitution #7310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Zhen Wang <643348094@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7310 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 698 698
Lines 43649 43654 +5
Branches 5894 5896 +2
======================================
- Misses 43649 43654 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wForget
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pan3793 , LGTM
|
thanks, merging to master |
Why are the changes needed?
This PR enhances
kyuubi.metrics.json.locationto support variable substitution:{{KYUUBI_HOME}},{{KYUUBI_WORK_DIR_ROOT}}, and changes the default value to{{KYUUBI_HOME}}/metrics- I suppose it is a more reasonable default value than{{KYUUBI_WORK_DIR_ROOT}}/metrics, given others dirs also underKYUUBI_HOMEby defaultTo make things more consistent, variable substitution behavior is also updated for
kyuubi.metadata.store.jdbc.urlHow was this patch tested?
Manually tested by
and checks the metrics JSON file.
Was this patch authored or co-authored using generative AI tooling?
No.