feat: add tab select with save chart to dashboard#36332
feat: add tab select with save chart to dashboard#36332EnxDev merged 73 commits intoapache:masterfrom
Conversation
This reverts commit 35aaeb6.
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #bcacb9
Actionable Suggestions - 1
-
superset-frontend/src/explore/components/SaveModal.tsx - 1
- Inconsistent enum vs string usage · Line 105-107
Additional Suggestions - 1
-
superset-frontend/src/explore/types.ts - 1
-
Misleading enum name · Line 38-41The newly added enum is named ChartStatusType, but its values ('overwrite' and 'saveas') are for save actions, not chart statuses. This is confusing given the existing ChartStatus type for rendering states. Renaming it to something like SaveActionEnum would improve clarity and maintainability.
-
Review Details
-
Files reviewed - 4 · Commit Range:
127cdaf..b026c1e- superset-frontend/src/dashboard/constants.ts
- superset-frontend/src/explore/components/SaveModal.test.jsx
- superset-frontend/src/explore/components/SaveModal.tsx
- superset-frontend/src/explore/types.ts
-
Files skipped - 0
-
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| action: this.canOverwriteSlice() | ||
| ? ChartStatusType.overwrite | ||
| : ChartStatusType.saveas, |
There was a problem hiding this comment.
The refactoring introduces ChartStatusType enum but inconsistently mixes it with string literals for action values. While functionally equivalent since enum values are strings, this creates maintenance risk if enum values change. For example, comparisons like this.state.action === 'overwrite' should use ChartStatusType.overwrite for type safety.
Code Review Run #bcacb9
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
EnxDev
added
the
🎪 ⚡ showtime-trigger-start
github-actions
bot
added
🎪 b026c1e 🚦 building
github-actions
bot
added
🎪 b026c1e 🚦 deploying
|
🎪 Showtime deployed environment on GHA for b026c1e • Environment: http://54.218.123.95:8080 (admin/admin) |
Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com> (cherry picked from commit c30edaf)
sadpandajoe
added
🎪 🛑 showtime-trigger-stop
4 participants
User description
SUMMARY
Users can now select a specific tab when saving a chart to a dashboard. This allows for more precise control over chart placement in complex dashboards with multiple tabs.
Add the ability to select a tab in the chart save modal window when placing it on a dashboard:
Added
TreeSelectfrom Ant Design for tab selectionBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
demo2_can_select_tab.webm
TESTING INSTRUCTIONS
run test src/explore/components/SaveModal.test.jsx
ADDITIONAL INFORMATION
CodeAnt-AI Description
Let users pick a dashboard tab when saving a chart
What Changed
Impact
✅ Easier chart placement on multi-tab dashboards✅ Quicker access to newly saved charts✅ Clearer feedback when tab placement fails💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.