feat: provide full endpoint URL construction for plugin developers #37360

innovark37 · 2026-01-22T10:33:06Z

SUMMARY

This PR provides plugin developers with the ability to construct fully-qualified Superset endpoint URLs, including the application root prefix, regardless of deployment configuration.

The Core Problem

External plugins lack access to Superset's deployment context and cannot reliably construct endpoint URLs. When Superset is deployed at a non-root path (e.g., /superset, /analytics, custom prefix), plugins have no way to know this prefix and thus cannot create correct URLs.

Solution

Expose a getUrl() method via SupersetClient (already available through @superset-ui/core) that resolves paths with the correct application context.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-01-22T10:33:16Z

Code Review Agent Run #a313b2

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 342351e..366bd3b
- superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts
- superset-frontend/packages/superset-ui-core/src/connection/types.ts
- superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

netlify · 2026-01-22T10:36:46Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`342351e`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6971fce662d5200008ab6fa7
😎 Deploy Preview	https://deploy-preview-37360--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review · 2026-01-22T11:50:26Z

Code Review Agent Run #24a77f

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 342351e..366bd3b
- superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts
- superset-frontend/packages/superset-ui-core/src/connection/types.ts
- superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

Copilot

Pull request overview

This PR exposes the existing getUrl() method from SupersetClientClass through the SupersetClient singleton interface, enabling external plugin developers to construct fully-qualified Superset endpoint URLs with the correct application root prefix.

Changes:

Exposed getUrl method through SupersetClient singleton wrapper
Added getUrl to the SupersetClientInterface type definition
Updated test suite to verify the new public API surface

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts	Added delegation from `SupersetClient.getUrl` to underlying `SupersetClientClass` instance
superset-frontend/packages/superset-ui-core/src/connection/types.ts	Added `getUrl` to the `SupersetClientInterface` Pick type
superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts	Updated tests to include `getUrl` in method exposure checks and pre-configuration error checks

superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts

bito-code-review · 2026-01-23T19:54:01Z

Yes, adding a functional test for getUrl after configuration would improve test coverage and match the pattern for other methods. It ensures the delegation to the instance works correctly with appRoot prefixing.

superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts

SupersetClient.configure({ appRoot: '/app' });
    const url = SupersetClient.getUrl({ endpoint: '/some/path' });
    expect(url).toBe('/app/some/path');

sadpandajoe · 2026-01-26T18:33:45Z

@martyngigg mind taking a look at this?

rusackas · 2026-02-02T08:00:01Z

Did you want to address or refute the bot suggestion before merging?

innovark37 · 2026-02-03T08:11:23Z

@rusackas
Bot suggestion was resolved

bito-code-review · 2026-02-03T08:55:38Z

Code Review Agent Run #1c0fea

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 366bd3b..38c93f5
- superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts
- superset-frontend/packages/superset-ui-core/src/connection/types.ts
- superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

martyngigg

@sadpandajoe Sorry for the delay in getting to this.

It seems to make sense to me and exposes an existing method with extra tests so I can't see an issue.

feat: add getUrl method to SupersetClient interface

342351e

pull-request-size bot added the size/XS label Jan 22, 2026

github-actions bot added the packages label Jan 22, 2026

dosubot bot added the api Related to the REST API label Jan 22, 2026

test: update test for SupersetClient

366bd3b

pull-request-size bot added size/S and removed size/XS labels Jan 22, 2026

github-actions bot removed the api Related to the REST API label Jan 22, 2026

rusackas requested review from Copilot and sadpandajoe January 23, 2026 19:48

Copilot started reviewing on behalf of rusackas January 23, 2026 19:48 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts Show resolved Hide resolved

sadpandajoe approved these changes Jan 27, 2026

View reviewed changes

sadpandajoe requested review from Vitor-Avila and michael-s-molina January 27, 2026 01:04

test: update test

38c93f5

pull-request-size bot added size/M and removed size/S labels Feb 3, 2026

martyngigg approved these changes Feb 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: provide full endpoint URL construction for plugin developers #37360

feat: provide full endpoint URL construction for plugin developers #37360

innovark37 commented Jan 22, 2026

Uh oh!

bito-code-review bot commented Jan 22, 2026 •

edited

Loading

Code Review Agent Run #a313b2

Uh oh!

netlify bot commented Jan 22, 2026

Uh oh!

bito-code-review bot commented Jan 22, 2026 •

edited

Loading

Code Review Agent Run #24a77f

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

bito-code-review bot commented Jan 23, 2026

Uh oh!

sadpandajoe commented Jan 26, 2026

Uh oh!

rusackas commented Feb 2, 2026

Uh oh!

innovark37 commented Feb 3, 2026

Uh oh!

bito-code-review bot commented Feb 3, 2026 •

edited

Loading

Code Review Agent Run #1c0fea

Uh oh!

martyngigg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: provide full endpoint URL construction for plugin developers #37360

Are you sure you want to change the base?

feat: provide full endpoint URL construction for plugin developers #37360

Conversation

innovark37 commented Jan 22, 2026

SUMMARY

The Core Problem

Solution

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #a313b2

Uh oh!

netlify bot commented Jan 22, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #24a77f

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

bito-code-review bot commented Jan 23, 2026

Uh oh!

sadpandajoe commented Jan 26, 2026

Uh oh!

rusackas commented Feb 2, 2026

Uh oh!

innovark37 commented Feb 3, 2026

Uh oh!

bito-code-review bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #1c0fea

Uh oh!

martyngigg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bito-code-review bot commented Jan 22, 2026 •

edited

Loading

bito-code-review bot commented Jan 22, 2026 •

edited

Loading

bito-code-review bot commented Feb 3, 2026 •

edited

Loading