feat(embedded): add feature flag to disable logout button in embedded contexts #37537

richardfogaca · 2026-01-29T00:34:16Z

SUMMARY

This PR introduces a new feature flag DISABLE_EMBEDDED_SUPERSET_LOGOUT that hides the logout button when Superset is embedded via iframe in SSO-managed authentication flows.

Use Case: When Superset is embedded within a parent application that manages authentication via SSO, the logout button in Superset becomes problematic:

Users logging out of Superset while remaining in the parent app creates a confusing experience
The parent application should control the authentication lifecycle, not the embedded Superset instance
Clicking logout in the iframe may break the SSO session or cause unexpected behavior

Solution: A feature flag that conditionally hides the logout menu item in the Settings dropdown, allowing administrators to disable logout functionality in embedded deployments while preserving it for standalone use.

Changes:

Backend (superset/config.py): Added DISABLE_EMBEDDED_SUPERSET_LOGOUT to DEFAULT_FEATURE_FLAGS with default value False, including @docs annotation linking to documentation
Frontend enum (featureFlags.ts): Added DisableEmbeddedSupersetLogout TypeScript enum entry
RightMenu component (RightMenu.tsx): Wrapped logout menu item in conditional check using isFeatureEnabled()
Tests (RightMenu.test.tsx): Added 2 new tests covering both enabled and disabled states
Documentation (docs/docs/configuration/networking-settings.mdx): Added "Hiding the Logout Button in Embedded Contexts" section under HTML Embedding

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE (Flag Disabled - Default Behavior):
Settings menu shows the Logout option as expected.

AFTER (Flag Enabled):
Settings menu no longer shows the Logout option - users must log out through the parent application.

TESTING INSTRUCTIONS

Unit Tests

cd superset-frontend
npm run test -- src/features/home/RightMenu.test.tsx

All 9 tests pass, including:

shows logout button when DISABLE_EMBEDDED_SUPERSET_LOGOUT is false
hides logout button when DISABLE_EMBEDDED_SUPERSET_LOGOUT is true

Manual Testing

Test with flag disabled (default):
- Start Superset normally
- Log in and click Settings dropdown
- Verify "Logout" option is visible
Test with flag enabled:
- Add to superset_config.py:
```
FEATURE_FLAGS = {
    'DISABLE_EMBEDDED_SUPERSET_LOGOUT': True,
}
```
- Restart Superset
- Log in and click Settings dropdown
- Verify "Logout" option is not visible
Test in iframe context:
- Create a simple HTML page with Superset in an iframe:
```
<iframe src="http://localhost:8088" width="100%" height="800"></iframe>
```
- With flag enabled, confirm logout is hidden
- With flag disabled, confirm logout is visible

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags: DISABLE_EMBEDDED_SUPERSET_LOGOUT
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

… contexts

bito-code-review · 2026-01-29T00:34:26Z

Code Review Agent Run #9e3d06

Actionable Suggestions - 0

Review Details

Files reviewed - 5 · Commit Range: 0cef9a3..0cef9a3
- docs/docs/configuration/networking-settings.mdx
- superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
- superset-frontend/src/features/home/RightMenu.test.tsx
- superset-frontend/src/features/home/RightMenu.tsx
- superset/config.py
Files skipped - 1
- docs/static/feature-flags.json - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

docs/docs/configuration/networking-settings.mdx

superset-frontend/src/features/home/RightMenu.test.tsx

superset-frontend/src/features/home/RightMenu.tsx

superset/config.py

netlify · 2026-01-29T00:41:43Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`0cef9a3`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/697aab0c6689670008831c2f
😎 Deploy Preview	https://deploy-preview-37537--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-01-29T00:47:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.33%. Comparing base (f6f9e08) to head (7f490be).
⚠️ Report is 50 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #37537       +/-   ##
===========================================
+ Coverage        0   66.33%   +66.33%     
===========================================
  Files           0      644      +644     
  Lines           0    49412    +49412     
  Branches        0     5544     +5544     
===========================================
+ Hits            0    32775    +32775     
- Misses          0    15337    +15337     
- Partials        0     1300     +1300

Flag	Coverage Δ
hive	`41.79% <ø> (?)`
mysql	`64.39% <ø> (?)`
postgres	`64.47% <ø> (?)`
presto	`41.81% <ø> (?)`
python	`66.30% <ø> (?)`
sqlite	`64.16% <ø> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ployments The logout link was missing the ensureAppRoot wrapper that other internal URLs (like user_info_url) already use, causing logout to 404 in subdirectory deployments.

bito-code-review · 2026-01-29T02:07:20Z

Code Review Agent Run #9724c4

Actionable Suggestions - 0

Review Details

Files reviewed - 5 · Commit Range: 0cef9a3..8404815
- docs/docs/configuration/networking-settings.mdx
- superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
- superset-frontend/src/features/home/RightMenu.test.tsx
- superset-frontend/src/features/home/RightMenu.tsx
- superset/config.py
Files skipped - 1
- docs/static/feature-flags.json - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

Antonio-RiveroMartnez · 2026-01-29T07:30:52Z

superset-frontend/src/features/home/RightMenu.tsx

-          ),
-          onClick: handleLogout,
-        });
+        if (!isFeatureEnabled(FeatureFlag.DisableEmbeddedSupersetLogout)) {


Isn't more aligned with our existing patterns to use a permission for hide/show a menu? Was there any reason why that wouldn't work on embedded envs?

Good question! The feature flag is actually the right approach here — permissions are per-role (RBAC), but hiding logout in an embedded deployment is a system-wide concern, not a per-user one. There's no existing can_logout permission in FAB, and creating one would conflate authorization with deployment topology.

There's also direct precedent for this: MENU_HIDE_USER_INFO uses a feature flag for the "Info" item in the same menu (views/base.py:307).

bito-code-review · 2026-02-03T03:15:36Z

Code Review Agent Run #3608dd

Actionable Suggestions - 0

Review Details

Files reviewed - 5 · Commit Range: 8404815..7f490be
- docs/docs/configuration/networking-settings.mdx
- superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
- superset-frontend/src/features/home/RightMenu.test.tsx
- superset-frontend/src/features/home/RightMenu.tsx
- superset/config.py
Files skipped - 1
- docs/static/feature-flags.json - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

feat(embedded): add feature flag to disable logout button in embedded…

0cef9a3

… contexts

pull-request-size bot added the size/M label Jan 29, 2026

github-actions bot added the doc Namespace | Anything related to documentation label Jan 29, 2026

github-actions bot added the packages label Jan 29, 2026

dosubot bot added change:backend Requires changing the backend change:frontend Requires changing the frontend labels Jan 29, 2026

richardfogaca requested review from EnxDev, alexandrusoare, amaannawab923, betodealmeida, msyavuz, rusackas and sadpandajoe January 29, 2026 00:36

codeant-ai-for-open-source bot reviewed Jan 29, 2026

View reviewed changes

fix(embedded): wrap logout URL with ensureAppRoot for subdirectory de…

8404815

…ployments The logout link was missing the ensureAppRoot wrapper that other internal URLs (like user_info_url) already use, causing logout to 404 in subdirectory deployments.

Antonio-RiveroMartnez reviewed Jan 29, 2026

View reviewed changes

fix: prettier

7f490be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(embedded): add feature flag to disable logout button in embedded contexts #37537

feat(embedded): add feature flag to disable logout button in embedded contexts #37537

richardfogaca commented Jan 29, 2026 •

edited

Loading

Uh oh!

bito-code-review bot commented Jan 29, 2026 •

edited

Loading

Code Review Agent Run #9e3d06

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 29, 2026

Uh oh!

codecov bot commented Jan 29, 2026 •

edited

Loading

Uh oh!

bito-code-review bot commented Jan 29, 2026 •

edited

Loading

Code Review Agent Run #9724c4

Uh oh!

Antonio-RiveroMartnez Jan 29, 2026

Uh oh!

richardfogaca Feb 3, 2026

Uh oh!

bito-code-review bot commented Feb 3, 2026 •

edited

Loading

Code Review Agent Run #3608dd

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(embedded): add feature flag to disable logout button in embedded contexts #37537

Are you sure you want to change the base?

feat(embedded): add feature flag to disable logout button in embedded contexts #37537

Conversation

richardfogaca commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Unit Tests

Manual Testing

ADDITIONAL INFORMATION

Uh oh!

bito-code-review bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9e3d06

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 29, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

codecov bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bito-code-review bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9724c4

Uh oh!

Antonio-RiveroMartnez Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3608dd

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richardfogaca commented Jan 29, 2026 •

edited

Loading

bito-code-review bot commented Jan 29, 2026 •

edited

Loading

codecov bot commented Jan 29, 2026 •

edited

Loading

bito-code-review bot commented Jan 29, 2026 •

edited

Loading

bito-code-review bot commented Feb 3, 2026 •

edited

Loading