Skip to content

Conversation

@rusackas
Copy link
Member

@rusackas rusackas commented Feb 3, 2026

SUMMARY

The deck.gl plugin dependencies were bumped to ~9.2.5/~9.2.6 by Dependabot across several PRs, but the root package.json overrides section was never updated to match — it still pinned all @deck.gl/* and @luma.gl/* packages to ~9.2.2.

This caused WebGL shader compilation errors at runtime on the deck.gl Demo dashboard:

  • DECKGL_FILTER_COLOR: no matching overloaded function found in ScreenGrid, Grid, and Hexagon layers
  • geometry: undeclared identifier in the screen-grid fragment shader

Root cause: The overrides forced older @luma.gl/shadertools (9.2.2) to be used alongside newer @deck.gl/aggregation-layers (9.2.5). The aggregation layers' GPU shaders emit DECKGL_FILTER_COLOR calls with a signature that changed between 9.2.2 and 9.2.5, causing the shader compilation mismatch.

Fix: Update all deck.gl/luma.gl overrides in root package.json to match the versions required by the plugin:

  • @deck.gl/* packages: ~9.2.2~9.2.5
  • @luma.gl/engine, @luma.gl/shadertools: ~9.2.2~9.2.6
  • @luma.gl/core, @luma.gl/constants, @luma.gl/webgl: ~9.2.2~9.2.6 (ensures single version deduplication to avoid TypeScript Device type conflicts)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Deck.gl Screen Grid, Grid, and Hexagon charts show WebGL shader compilation errors
After: Charts render correctly

TESTING INSTRUCTIONS

  1. Open the "deck.gl Demo" dashboard
  2. Verify the Deck.gl Screen grid, Deck.gl Grid, and Deck.gl Hexagons charts render without shader errors
  3. Verify all other deck.gl charts (Scatterplot, Arcs, Path, Polygons) still work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

…ions

Dependabot bumped deck.gl plugin dependencies to ~9.2.5/~9.2.6 across
several PRs, but the root package.json overrides section still pinned
all deck.gl and luma.gl packages to ~9.2.2. This forced older
luma.gl/shadertools (9.2.2) to be used with newer deck.gl aggregation
layers (9.2.5), causing DECKGL_FILTER_COLOR shader compilation errors
at runtime on the ScreenGrid, Grid, and Hexagon layers.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 3, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@dosubot dosubot bot added the viz:charts:deck.gl Related to deck.gl charts label Feb 3, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

The PR updates root package.json overrides so deck.gl plugins and luma.gl packages use matching compatible versions. This ensures shaders generated by aggregation layers match shadertools signatures, preventing WebGL compilation errors and allowing Deck.gl demo charts to render.

sequenceDiagram
    participant Dev as Developer (PR)
    participant PackageMgr as Package Manager (npm)
    participant DeckPlugin as deck.gl Plugin (aggregation-layers...)
    participant Luma as luma.gl Shadertools
    participant Browser as Demo Dashboard

    Dev->>PackageMgr: Update overrides in root package.json to ~9.2.5 / ~9.2.6
    PackageMgr->>DeckPlugin: Install matching @deck.gl/* versions
    PackageMgr->>Luma: Install matching @luma.gl/* versions
    DeckPlugin->>Luma: Emit shaders using updated DECKGL_FILTER_COLOR signature
    Luma-->>Browser: Compile shaders successfully
    Browser-->>Dev: Deck.gl Demo charts render (no shader errors)
Loading

Generated by CodeAnt AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant