Skip to content

Conversation

@Vitor-Avila
Copy link
Contributor

@Vitor-Avila Vitor-Avila commented Feb 3, 2026

SUMMARY

This is a follow up to: #35896. It properly untracks the config file for the websocket service for Docker, so that changes are git-ignored.

Added notes to UPDATING to avoid any impact.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 3, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@dosubot dosubot bot added the install:docker Installation - docker container label Feb 3, 2026
@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 4ee88d7
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6981f968c089f80008332b8d
😎 Deploy Preview https://deploy-preview-37624--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Vitor-Avila Vitor-Avila force-pushed the chore/docker-untrack-config-file branch from f5a61e8 to 4ee88d7 Compare February 3, 2026 13:34
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR removes the tracked default websocket config, adds guidance to UPDATING, and expects users to keep a local docker/superset-websocket/config.json that is git-ignored and mounted into the superset-websocket container. The diagram shows the main success path for how a developer provides the config to the running Docker service.

sequenceDiagram
    participant Developer
    participant GitRepo
    participant DockerCompose
    participant superset-websocket

    Developer->>GitRepo: Keep local docker/superset-websocket/config.json (git-ignored)
    Developer->>DockerCompose: Start services (docker-compose up)
    DockerCompose->>superset-websocket: Mount local config.json into container
    superset-websocket-->>DockerCompose: Read configuration and start WebSocket server
    superset-websocket-->>Developer: WebSocket service running with local config
Loading

Generated by CodeAnt AI

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems like we should have never tracked this file in the first place.

@Vitor-Avila Vitor-Avila merged commit 32ee160 into master Feb 3, 2026
61 checks passed
@Vitor-Avila Vitor-Avila deleted the chore/docker-untrack-config-file branch February 3, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install:docker Installation - docker container size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants