Skip to content

fix(docker): remove accidental command substitutions when building FE in dev mode#37670

Merged
hainenber merged 1 commit intomasterfrom
build/fix-accidental-cmd-substitution
Feb 4, 2026
Merged

fix(docker): remove accidental command substitutions when building FE in dev mode#37670
hainenber merged 1 commit intomasterfrom
build/fix-accidental-cmd-substitution

Conversation

@hainenber
Copy link
Contributor

fix(docker): remove accidental command substitutions when building FE in dev mode

SUMMARY

Fixes #37662
Fixes accidental backticks which are used for command substitution in shell scripting. Plus, we don't have to run commands twice. Thanks to @jerry000lin for noticing this out!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

All checks to be green, especially the docker-compose sanity tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 4, 2026

Code Review Agent Run #01873b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 4df7c57..4df7c57
    • docker/docker-frontend.sh
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the install:docker Installation - docker container label Feb 4, 2026
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 4df7c57
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6983514949f4540008c868a6
😎 Deploy Preview https://deploy-preview-37670--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hainenber hainenber merged commit f96e90b into master Feb 4, 2026
71 checks passed
@hainenber hainenber deleted the build/fix-accidental-cmd-substitution branch February 4, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install:docker Installation - docker container size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-frontend.sh runs npm commands twice because backticks in echo trigger command substitution

2 participants