feat(dvt): add ProcessControl instrument for process management #136
Conversation
| */ | ||
| export interface ProcessControlService { | ||
| /** | ||
| * Send a signal to a process |
There was a problem hiding this comment.
what happens if pid does not exist?
| kill(pid: number): Promise<void>; | ||
|
|
||
| /** | ||
| * Disable memory limits for a specific process |
There was a problem hiding this comment.
how does this work? what are the default memory limits?
| * @param bundleId The bundle identifier | ||
| * @returns The process identifier (PID) | ||
| */ | ||
| processIdentifierForBundleIdentifier(bundleId: string): Promise<number>; |
There was a problem hiding this comment.
what happens if bundleId does not exist?
There was a problem hiding this comment.
consider including a verb to the method name
| * Disable memory limits for a specific process | ||
| * @param pid The process identifier | ||
| */ | ||
| disableMemoryLimitForPid(pid: number): Promise<void>; |
There was a problem hiding this comment.
what happens if this method is called twice on the same process?
| const result = await this.channel!.receivePlist(); | ||
|
|
||
| if (typeof result !== 'number') { | ||
| throw new Error(`Failed to launch process: ${JSON.stringify(result)}`); |
There was a problem hiding this comment.
please document this behavior
| * Encodes JavaScript objects into NSKeyedArchiver format | ||
| * capable of satisfying NSSecureCoding requirements. | ||
| */ | ||
| export class NSKeyedArchiverEncoder { |
There was a problem hiding this comment.
Is this class covered by unit tests?
|
|
||
| const log = logger.getLogger('ProcessControl.test'); | ||
|
|
||
| describe('ProcessControl Service', function () { |
There was a problem hiding this comment.
It would be nice to have some tests for outputEvents generator, we can add steps/requirements as comments in tests if required.
No description provided.