Skip to content

[Keyless Common] Various cleanups, refactors and improvements to the keyless-common directory.#103

Merged
JoshLind merged 7 commits intomainfrom
JoshLind-patch-22
Nov 30, 2025
Merged

[Keyless Common] Various cleanups, refactors and improvements to the keyless-common directory.#103
JoshLind merged 7 commits intomainfrom
JoshLind-patch-22

Conversation

@JoshLind
Copy link
Contributor

What is the change being pushed?

This PR offers the following commits:

  1. Clean up bits.rs (and add a simple test), and split groth16_vk.rs into two files (snark_js_groth16.rs and types.rs).
  2. Rename config.rs -> circuit_config.rs.
  3. Clean up circuit_config.rs and harden file loading using serde.
  4. Move the test witness generation logic into the circuit directory, and add simple tests to the circuit config code.
  5. Clean up sha.rs and remove the code duplication between compute_sha_padding and compute_sha_padding_without_length. Now, a flag determines if the length should be included.
  6. Split up encoding.rs, remove the JWT related content (and create a jwt.rs file), and move trait implementations to appropriate places.
  7. Clean up circuit_input_signals.rs.

Note: other than cleanups, refactors and reorganization, nothing should logically change.

Testing Plan

New and existing test infrastructure.

@JoshLind JoshLind requested review from alinush and zjma November 29, 2025 14:46
@JoshLind JoshLind merged commit 73960dd into main Nov 30, 2025
4 checks passed
@JoshLind JoshLind deleted the JoshLind-patch-22 branch November 30, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants