[Keyless Common] Various cleanups, refactors and improvements to the keyless-common directory.#103
Merged
[Keyless Common] Various cleanups, refactors and improvements to the keyless-common directory.#103
Conversation
alinush
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change being pushed?
This PR offers the following commits:
bits.rs(and add a simple test), and splitgroth16_vk.rsinto two files (snark_js_groth16.rsandtypes.rs).config.rs->circuit_config.rs.circuit_config.rsand harden file loading usingserde.sha.rsand remove the code duplication betweencompute_sha_paddingandcompute_sha_padding_without_length. Now, a flag determines if the length should be included.encoding.rs, remove the JWT related content (and create ajwt.rsfile), and move trait implementations to appropriate places.circuit_input_signals.rs.Note: other than cleanups, refactors and reorganization, nothing should logically change.
Testing Plan
New and existing test infrastructure.