ESA HST & ISLA: abstract EsaTap using PyVO, HST and ISLA refactored

[jespinosaar]

Dear Astroquery team,

As part of the migration to PyVO, we have generated a more general class called EsaTap, extending PyVO capabilities with custom code (authentication, parameters in the request, methods to query tables with specific filters...). We will be using this class to extend ESA modules, so the common code will remain under EsaTap and the mission-specific methods will be defined in their specific modules. As a reference, we have already applied this approach to eHST and ISLA. Please let us know if this is ok with you.

Happy to receive your feedback and implement any change you require!

Kind regards,
@jespinosaar

cc @esdc-esac-esa-int

[codecov]

Codecov Report

❌ Patch coverage is 87.42857% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.88%. Comparing base (27a673d) to head (8180cf3).
⚠️ Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/esa/utils/utils.py	86.07%	22 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3501      +/-   ##
==========================================
+ Coverage   71.73%   71.88%   +0.14%     
==========================================
  Files         235      235              
  Lines       20258    20362     +104     
==========================================
+ Hits        14533    14638     +105     
+ Misses       5725     5724       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jespinosaar]

Ok, after some iterations I managed to have this fixed and compliant with all checks, except for the docs one. But it seems that this is due to an unrelated error. @bsipocz , can you please have a look at it and let me know if further updates are needed? Many thanks!

[bsipocz]

Yes, RTD has a known failure, please ignore it for now while I'm fixing it separately.

Otherwise, wow, this PR looks great. I'll come back with a review once I clear some review backlog for the other PRs. I will also try to see how much of the customisation could actually be upstreamed into pyvo itself.

[jespinosaar]

Yes, RTD has a known failure, please ignore it for now while I'm fixing it separately.

Otherwise, wow, this PR looks great. I'll come back with a review once I clear some review backlog for the other PRs. I will also try to see how much of the customisation could actually be upstreamed into pyvo itself.

Glad to hear that! many thanks and happy weekend!

[jespinosaar]

Hi @bsipocz , we have been preparing other missions making use of this new approach and they are almost ready. Is it ok with you if we add them to this PR? or maybe should we wait until this one is merged and then create a new one? They are basic, just extending the EsaTap class and adding two specific methods each, this is why I am asking. Thanks in advance!

[jespinosaar]

Wrongly closed, but I will create another PR with more information.