feat(cli): updates and improvements #155
Open
+297
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds automatic creation/merging of a project-level .npmrc when pnpm is selected, ensuring required settings are present. Introduces a helper to write default pnpm config and safely append it if missing or incomplete. Preserves existing content and supports in-project setups. Updates tests to verify .npmrc creation in the project root during setup. Removes default in-repo .npmrc in common.
Adds new lean presets and minimal app presets powered by Vite, updating existing presets to use Vite/Vitest instead of Webpack. Introduces Vite-based plugin support with a CSS-injection mechanism to embed CSS into JS for Shadow DOM builds. Extends CLI prompts and samples to reflect the new presets, adds blank/minimal/router scaffolds, and updates router-tailwind samples accordingly. Aligns tests, lint rules, and docs with the new tooling and bump Storybook integration to compatible versions.
This was
linked to
issues
Jan 24, 2026
bigopon
reviewed
Jan 24, 2026
|
|
||
| Object.values(bundle).forEach((chunk) => { | ||
| if (chunk.type === 'chunk' && chunk.isEntry) { | ||
| chunk.code = `${injection}${chunk.code}`; |
Member
There was a problem hiding this comment.
Wont this destroy sourcemap? Should we append it instead
3cp
requested changes
Jan 24, 2026
Member
3cp
left a comment
3cp
left a comment
There was a problem hiding this comment.
Looks great! Thx for the hard work.
Only few minor touches for you to consider.
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const PNPM_NPMRC = [ |
Member
There was a problem hiding this comment.
Why not use?
const PNPM_NPMRC = `# for pnpm, use flat node_modules
shamefully-hoist=true
auto-install-peers=true
`;| It builds plugin into `dist/index.js` file. | ||
|
|
||
| // @if vite | ||
| When using Vite, the build outputs ESM to `dist/index.js`. |
Member
There was a problem hiding this comment.
Note common/package.json has following lines need attention.
// TODO: turn on after moved plugin to vite steup
// "type": "module",
You would want to turn it on.
| message: 'Which bundler would you like to use?', | ||
| choices: [ | ||
| {if: 'app', value: 'vite', title: 'Vite', hint: 'Next Generation Frontend Tooling.'}, | ||
| {if: 'app || plugin', value: 'vite', title: 'Vite', hint: 'Next Generation Frontend Tooling.'}, |
Member
There was a problem hiding this comment.
Should just remove this if condition instead of broadening it.
| choices: [ | ||
| {title: 'No'}, | ||
| {if: '(app && (vite || webpack)) || (plugin && webpack)', value: 'storybook', title: 'Yes', hint: 'Add Storybook for component development and testing (requires Vite or Webpack)'} | ||
| {if: '(app || plugin) && (vite || webpack)', value: 'storybook', title: 'Yes', hint: 'Add Storybook for component development and testing (requires Vite or Webpack)'} |
Member
There was a problem hiding this comment.
Sound like you only need if: 'vite || webpack'.
| // @endif | ||
| // @endif | ||
| // @if plugin | ||
| function cssInjectPlugin() { |
Member
There was a problem hiding this comment.
Should not this whole cssInjectPlugin be another export from our @aurelia/vite-plugin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new lean presets and minimal app presets powered by Vite, updating existing presets to use Vite/Vitest instead of Webpack. Introduces Vite-based plugin support with a CSS-injection mechanism to embed CSS into JS for Shadow DOM builds. Extends CLI prompts and samples to reflect the new presets, adds blank/minimal/router scaffolds, and updates router-tailwind samples accordingly. Aligns tests, lint rules, and docs with the new tooling and bump Storybook integration to compatible versions.
Closes #154 #153 #152