-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(eks-v2-alpha): pass additional helm chart values to aws-load-balancer-controller #36754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||||||||||||||
|
|
||||||||||||||
a975b16 to
b7fbb9f
Compare
eaf332e to
7ef548d
Compare
7ef548d to
04779c9
Compare
abidhasan-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 34dcb68 This pull request spent 58 minutes 28 seconds in the queue, including 43 minutes 20 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
Currently passing in additional value to ALB helm chart is not supported.
List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199.
This brings a feature in v1 that is missing in v2. See #34077 for original PR.
Note: This intentionally uses a JSON instead of strong typing all the values for the HelmChart because there are so many options to maintain. In EKS V1, only
enableWafandenableWafv2were added as a response to the original issue, without allowing any other option which is perhaps not the best decision since theHelmChartsupports all options as JSON instead of strong typing.See https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml for the allowed values.
Description of changes
Added
additionalHelmChartValuesto AlbController propertiesDescribe any new or updated permissions being added
None
Description of how you validated changes
Integ + unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license