Skip to content

Conversation

@aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Jan 21, 2026

Issue # (if applicable)

Reason for this change

Currently passing in additional value to ALB helm chart is not supported.
List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199.

This brings a feature in v1 that is missing in v2. See #34077 for original PR.

Note: This intentionally uses a JSON instead of strong typing all the values for the HelmChart because there are so many options to maintain. In EKS V1, only enableWaf and enableWafv2 were added as a response to the original issue, without allowing any other option which is perhaps not the best decision since the HelmChart supports all options as JSON instead of strong typing.

See https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml for the allowed values.

Description of changes

Added additionalHelmChartValues to AlbController properties

Describe any new or updated permissions being added

None

Description of how you validated changes

Integ + unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2026 16:22
@github-actions github-actions bot added the p2 label Jan 21, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results24 ran24 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates24 ran24 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Jan 21, 2026
@aemada-aws aemada-aws marked this pull request as draft January 21, 2026 16:37
@aemada-aws aemada-aws force-pushed the helm-alpha-v2 branch 2 times, most recently from eaf332e to 7ef548d Compare January 21, 2026 16:44
@aws-cdk-automation aws-cdk-automation removed the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Jan 21, 2026
@aemada-aws aemada-aws marked this pull request as ready for review January 22, 2026 10:05
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 22, 2026
Copy link
Contributor

@abidhasan-aws abidhasan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Merge Queue Status

✅ The pull request has been merged at 34dcb68

This pull request spent 58 minutes 28 seconds in the queue, including 43 minutes 20 seconds running CI.
The checks were run in-place.

Required conditions to merge

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 27, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cf61814 into main Jan 27, 2026
22 of 23 checks passed
@mergify mergify bot deleted the helm-alpha-v2 branch January 27, 2026 16:12
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants