fix(ec2): add VPC endpoint naming conventions for some isolated regions #36794
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: Integration tests cannot be added for these isolated regions (us-iso-, us-isob-, us-isof-*) as they require special AWS credentials and access that aren't available in the public CDK CI environment. The unit tests provide adequate coverage for the naming convention logic without requiring the CDK developers to expand their testing tooling into all AWS Partitions |
aws-cdk-automation
added
the
pr-linter/exemption-requested
bk5115545
changed the title
Add correct VPC endpoint prefixes for several AWS isolated regions: - us-iso-east-1, us-iso-west-1: gov.ic.c2s - us-isob-east-1, us-isob-west-1: gov.sgov.sc2s - us-isof-south-1, us-isof-east-1: gov.ic.hci.csp This ensures VPC endpoints are correctly named for services in these isolated regions, matching the actual AWS service endpoint conventions. Includes comprehensive unit tests using test.each patterns for better maintainability and coverage.
bk5115545
force-pushed
the
fix/vpc-endpoint-isolated-regions
branch
from
8dcdb39 to
0dd765e
Compare
aws-cdk-automation
added
the
pr/needs-community-review
| 'sagemaker.runtime', 'sns', 'sqs', 'workspaces'], | ||
| 'us-isob-west-1': ['ecr.api', 'ecr.dkr', 'elasticfilesystem-fips', 'execute-api'], | ||
| 'us-isof-south-1': ['ebs', 'ecr.api', 'ecr.dkr', 'execute-api'], | ||
| 'us-isof-east-1': ['ebs', 'ecr.api', 'ecr.dkr', 'execute-api'], |
There was a problem hiding this comment.
Add eu-isoe-west-1 for completeness?
There was a problem hiding this comment.
I don't have access to or know anyone who can access eu-isoe-west-1 so I am not aware of the services that use special naming conventions. I'd rather not guess at these as that could break functional CDK templates.
4 participants
Add correct VPC endpoint prefixes for several AWS isolated regions:
gov.ic.c2sgov.sgov.sc2sgov.ic.hci.cspThis ensures VPC endpoints are correctly named for services in these isolated regions, matching the actual AWS service endpoint conventions.
Reason for this change
I'm tired of hearing about impact where specific services decided to use a different VPCE naming convention.
Description of changes
I updated the list of VPCE naming convention exceptions to cover all current VPCEs that exist in several ADC regions.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license