Skip to content

Conversation

@0xdsqr
Copy link
Contributor

@0xdsqr 0xdsqr commented Jan 24, 2026

Issue # (if applicable)

Na, live discussion.

Reason for this change

Add containerInsights: enhanced support for ecs clusters through a new EnableEnhancedContainerInsights mixin.

Description of changes

Created a new EnableEnhancedContainerInsights mixin to be leveraged by L1 or L2 ecs cluster constructs which enables enhanced container insights on a ecs cluster, per the specs outlined in the docs.

new ecs.CfnCluster(stack, 'L1Cluster', { clusterName: "test" })
  .with(new EnableEnhancedContainerInsights());

new ecs.Cluster(stack, 'L2Cluster', { vpc, clusterName: "test", }).
  with(new EnableEnhancedContainerInsights());

The docs note "Allowed values: containerInsights" as the only allowed key for ClusterSettings. This means we have no need for to find the key index, etc, a simply drop in replacement will do.

Description of how you validated changes

Unit and Integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2026 01:49
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 24, 2026
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates48 ran48 passed
TestResult
No test annotations available

@0xdsqr 0xdsqr force-pushed the 0xdsqr/mixins-preview-ecs-cluster-enhanced-container-insights branch from 5dc9d96 to 4f0e9ec Compare January 24, 2026 02:01
@0xdsqr 0xdsqr force-pushed the 0xdsqr/mixins-preview-ecs-cluster-enhanced-container-insights branch from 0664fc4 to 4270e1c Compare January 24, 2026 02:37
@0xdsqr
Copy link
Contributor Author

0xdsqr commented Jan 24, 2026

Exemption Request: Experimental Feature preview package

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 24, 2026
@0xdsqr
Copy link
Contributor Author

0xdsqr commented Jan 24, 2026

cc @mrgrain for pr-linter/exempt-readme label maybe?

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants