-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(mixin-preview): expose EnabledEnhacedContainerInsights as a pu…
#36796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(mixin-preview): expose EnabledEnhacedContainerInsights as a pu…
#36796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
|
||||||||||||||
|
|
||||||||||||||
5dc9d96 to
4f0e9ec
Compare
…blic facing mixin
0664fc4 to
4270e1c
Compare
|
Exemption Request: Experimental Feature preview package |
|
cc @mrgrain for |
Issue # (if applicable)
Na, live discussion.
Reason for this change
Add
containerInsights: enhancedsupport for ecs clusters through a newEnableEnhancedContainerInsightsmixin.Description of changes
Created a new
EnableEnhancedContainerInsightsmixin to be leveraged by L1 or L2 ecs cluster constructs which enables enhanced container insights on a ecs cluster, per the specs outlined in the docs.The docs note "Allowed values: containerInsights" as the only allowed
keyforClusterSettings. This means we have no need for to find the key index, etc, a simply drop in replacement will do.Description of how you validated changes
Unit and Integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license