Merge master into feature/stepfunctions-execution #8218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Note **There is still a little bit more work needed for fully migrating aws-sdk v2 to v3, specifically all of these clients [here](https://github.com/aws/aws-toolkit-vscode/blob/59fd17fcfa22798e78d0df196290edb4a070f7ec/packages/core/scripts/build/generateServiceClient.ts#L232-L251) from the `generateServiceClient.ts` script** ## Problem AWS SDK V2 is at EOL ## Solution Migrate AWS SDK V2 to V3 This work has been done in the `feature/v2-to-v3-migration` feature branch and thus merging it into `master` Here are the PRs, which this does not include the merges from main and resolving conflicts: - #8043 - #8042 - #8046 - #8054 - #8041 - #8056 - #8081 - #8069 - #8067 - #8093 - #8095 - #8094 - #8171 - #8159 - #8175 - #8182 ## Testing Manually tested the [prerelease builds](https://github.com/aws/aws-toolkit-vscode/releases/tag/pre-v2-to-v3-migration) https://github.com/user-attachments/assets/b1d4795c-4027-462e-a195-509ac4a9d8ae --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: Tai Lai <ctlai95@gmail.com> Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com> Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
## Problem When a user tries to connect to a SageMaker Space that is in the Stopped status (i.e., the underlying App is Deleted or has not been created), the Space will be automatically started by the toolkit before the connection is attempted. In some cases, the Space reaches the Running status (i.e., the App reaches the InService status) but the remote access capability is not yet ready as it starts asynchronously, leading to the SageMaker:StartSession API receiving an Internal Failure response. The client already retries, but the retries happen too quickly, before remote access becomes ready. ## Solution Adjust the SageMaker client retry configuration for StartSession calls made from the detached server (called via the `sagemaker_connect` script) to spread out the retries over multiple seconds. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
## Problem Some of the unit tests were flakey ## Solution Remove flakey test. We are okay to do this because the project scan flow is no longer in use --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Blake Lazarine <blakelaz@amazon.com>
- This merges the released changes for rc-20251022 into main. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
…8229) - migrating this PR: aws/aws-toolkit-vscode-staging#2248 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-ides-bot <github-aws-toolkit-automation@amazon.com> Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: tobixlea <tobixlea@amazon.com> Co-authored-by: Sherry Lu <75588211+XiaoxuanLu@users.noreply.github.com>
## Problem <img width="2353" height="362" alt="image" src="https://github.com/user-attachments/assets/4d98944f-8d7a-4dcd-98d2-8dd0e9fb1891" /> ## Solution - Skipping this test for now. Lambda team will work on a fix and reenable this soon. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem The test is checking for a popup to confirm overwrite of the SAM template. It is most likely getting blocked due to the "Scanning cloudformation template" warning popup that shows up before. ## Solution #3510 says disabling AWS SAM Codelens removes the aforementioned popup so I added a statement to disable the statement beforehand, and enabled it after this test runs so as not to impact other tests. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem This merges the released changes for rc-20251030 into main. MCM-137408423 ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: tobixlea <tobixlea@amazon.com> Co-authored-by: aws-toolkit-automation <>
## Problem Customer feedback about wanting more job attributes to be present in the job history table. ## Solution Add more info columns to the job history table. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <davhasan@amazon.com>
## Problem In the Amazon Q Welcome Walkthrough, the "Scan your current project" button under "Check for security vulnerabilities" feature is non-functional and does not initiate any scanning process when clicked. #### Steps to Reproduce - Click the 3-dot menu (⋯) above the chat interface - Select "Help" from the dropdown menu - Choose "Welcome Walkthrough" option - Navigate to "Check for security vulnerabilities" section - Click the "Scan your current project" button <img width="2778" height="1896" alt="image" src="https://github.com/user-attachments/assets/3e1a271a-c617-4e51-ae11-3fa538e54c3b" /> ## Solution - Remove this user experience as this is a part of agentic chat experience. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: seshubaws <116689586+seshubaws@users.noreply.github.com>
## Problem One of our previous PR: #7997 removed one of the intended user-agent for remote debugging. Adding this back ## Solution Add the intended user-agent back --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
#8249) ## Problem Users will face a host identification issue when reconnecting to a Space after restarting it, if the Space name has capital letters. This occurs because the Space's hostname is written to the known_hosts file in lowercase, but hostname matching during reconnection is case-sensitive. ## Solution When removing the Space hostname from the known_hosts file, ensure to remove lines that match the lowercase variant of the Space hostname. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
…n process (#8247) ## Problem Users had no idea what was happening during connecting to remote space, which can take few seconds to connect. User clicks "Connect" → Nothing visible happens for few seconds → Either success or failure ## Solution Adds progress tracking for SageMaker space connections which shows connection status with space name in progress dialog Test cases are not being added because it is just showing the user about progress during Space operations for good user experience. ## Testing Tested for both SM-AI and SMUS Spaces. 1. https://github.com/user-attachments/assets/20b02db3-7b6b-44d3-8e83-66d4e468da2c 2. https://github.com/user-attachments/assets/e2196483-b935-45d3-ae00-86e4163d298e --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
) Bumps the vscode-lsp group with 2 updates in the / directory: [vscode-languageclient](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client) and [vscode-languageserver](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server). Updates `vscode-languageclient` from 6.1.4 to 9.0.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/vscode-languageserver-node/releases">vscode-languageclient's releases</a>.</em></p> <blockquote> <h2>release/jsonrpc/9.0.0-next.9</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1665">#1665</a>: Update readme and move to NodeJS 22.x</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1663">#1663</a>: Remove implements Map from LinkedMap.</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1660">#1660</a>: Add capability information to <code>textDocument/colorPresentation</code></li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1650">#1650</a>: Update dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1646">#1646</a>: Bump brace-expansion from 2.0.1 to 2.0.2 in /client-node-tests</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1645">#1645</a>: Bump pbkdf2 from 3.1.2 to 3.1.3</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1644">#1644</a>: Use <code>MapIterator</code> return types in <code>LinkedMap</code> methods.</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1643">#1643</a>: Bump brace-expansion from 2.0.1 to 2.0.2 in /client</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1642">#1642</a>: Merge next release into main</li> </ul> <p>This list of changes was <a href="https://dev.azure.com/monacotools/Monaco/_build/results?buildId=352085&view=logs">auto generated</a>.</p> <h2>release/jsonrpc/9.0.0-next.8</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1632">#1632</a>: Read log level from output channel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1631">#1631</a>: Update general dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1630">#1630</a>: Use LogOutputChannel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1628">#1628</a>: Cancellation after first convert is not considered</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1629">#1629</a>: Fixes <a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1628">#1628</a>: Cancellation after first convert is not considered</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1619">#1619</a>: Test to trigger branch and PR build</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1618">#1618</a>: minor typo semaphore.ts</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1617">#1617</a>: Fix capabilities for range formatting requests</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1614">#1614</a>: fix: avoid dispose unmatched handlers</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1615">#1615</a>: Fix text document didOpen/didClose server capabilities</li> </ul> <!-- raw HTML omitted --> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1612">#1612</a>: Break cyclic dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1591">#1591</a>: Add capability information to the metamodel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1611">#1611</a>: Merge release into main</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1610">#1610</a>: Dbaeumer/novel-quokka-brown</li> </ul> <p>This list of changes was <a href="https://dev.azure.com/monacotools/Monaco/_build/results?buildId=337378&view=logs">auto generated</a>.<!-- raw HTML omitted --></p> <h2>release/jsonrpc/9.0.0-next.7</h2> <p>No release notes provided.</p> <h2>release/jsonrpc/9.0.0-next.6</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1543">#1543</a>: Trigger PR flow</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4f782ceac1b4444d335a32561bda0ded305c401e"><code>4f782ce</code></a> New release 3.17.5</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/8c81fc842c98059d705cb917b1ecca38ecbfb8e5"><code>8c81fc8</code></a> Update lock files (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1323">#1323</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/300fac4c24ebf634760baa9eb0607b4c5b8a1b24"><code>300fac4</code></a> Prepare new release (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1322">#1322</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/dfdb85d46f212e20de9df17074e84b97c4e7f95e"><code>dfdb85d</code></a> Fix folding range tests (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1320">#1320</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4e057d5d6109eb3fcb075d0f99456f05910fda44"><code>4e057d5</code></a> Add the workspace/foldingRange/refresh method (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1309">#1309</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/b6e99d84cb024057b4cee0b724f1017a3325a7f9"><code>b6e99d8</code></a> Add <code>MessageType.Debug</code> (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1264">#1264</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/c6817d36ffbc9efb17330b19e5e73a2caaa197d9"><code>c6817d3</code></a> Fixes <a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1313">#1313</a>: Capture the exit code of a server process and print it to the lo...</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/c880c618b131484a756b2ffe074d7af4d14a2782"><code>c880c61</code></a> Move to vscode version 1.82 (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1312">#1312</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/864c8c5db398b8f1d4fe4672edb68f3779a8e8a6"><code>864c8c5</code></a> Dbaeumer/frail-salamander-amber (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1311">#1311</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/fb0a3d48b9aa1c52d527f623164b0b4f11115d5a"><code>fb0a3d4</code></a> Move to lock file version 3 (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client/issues/1304">#1304</a>)</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/vscode-languageserver-node/commits/release/client/9.0.1/client">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~vscode-bot">vscode-bot</a>, a new releaser for vscode-languageclient since your current version.</p> </details> <br /> Updates `vscode-languageserver` from 6.1.1 to 9.0.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/vscode-languageserver-node/releases">vscode-languageserver's releases</a>.</em></p> <blockquote> <h2>release/jsonrpc/9.0.0-next.9</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1665">#1665</a>: Update readme and move to NodeJS 22.x</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1663">#1663</a>: Remove implements Map from LinkedMap.</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1660">#1660</a>: Add capability information to <code>textDocument/colorPresentation</code></li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1650">#1650</a>: Update dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1646">#1646</a>: Bump brace-expansion from 2.0.1 to 2.0.2 in /client-node-tests</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1645">#1645</a>: Bump pbkdf2 from 3.1.2 to 3.1.3</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1644">#1644</a>: Use <code>MapIterator</code> return types in <code>LinkedMap</code> methods.</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1643">#1643</a>: Bump brace-expansion from 2.0.1 to 2.0.2 in /client</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1642">#1642</a>: Merge next release into main</li> </ul> <p>This list of changes was <a href="https://dev.azure.com/monacotools/Monaco/_build/results?buildId=352085&view=logs">auto generated</a>.</p> <h2>release/jsonrpc/9.0.0-next.8</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1632">#1632</a>: Read log level from output channel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1631">#1631</a>: Update general dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1630">#1630</a>: Use LogOutputChannel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1628">#1628</a>: Cancellation after first convert is not considered</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1629">#1629</a>: Fixes <a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1628">#1628</a>: Cancellation after first convert is not considered</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1619">#1619</a>: Test to trigger branch and PR build</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1618">#1618</a>: minor typo semaphore.ts</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1617">#1617</a>: Fix capabilities for range formatting requests</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1614">#1614</a>: fix: avoid dispose unmatched handlers</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1615">#1615</a>: Fix text document didOpen/didClose server capabilities</li> </ul> <!-- raw HTML omitted --> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1612">#1612</a>: Break cyclic dependencies</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1591">#1591</a>: Add capability information to the metamodel</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1611">#1611</a>: Merge release into main</li> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1610">#1610</a>: Dbaeumer/novel-quokka-brown</li> </ul> <p>This list of changes was <a href="https://dev.azure.com/monacotools/Monaco/_build/results?buildId=337378&view=logs">auto generated</a>.<!-- raw HTML omitted --></p> <h2>release/jsonrpc/9.0.0-next.7</h2> <p>No release notes provided.</p> <h2>release/jsonrpc/9.0.0-next.6</h2> <h2>Changes:</h2> <ul> <li><a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1543">#1543</a>: Trigger PR flow</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4f782ceac1b4444d335a32561bda0ded305c401e"><code>4f782ce</code></a> New release 3.17.5</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/8c81fc842c98059d705cb917b1ecca38ecbfb8e5"><code>8c81fc8</code></a> Update lock files (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1323">#1323</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/300fac4c24ebf634760baa9eb0607b4c5b8a1b24"><code>300fac4</code></a> Prepare new release (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1322">#1322</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/3a21e09ff2358271bf86a3cea5b6568ad8846ff4"><code>3a21e09</code></a> Small formatting changes (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1319">#1319</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4e057d5d6109eb3fcb075d0f99456f05910fda44"><code>4e057d5</code></a> Add the workspace/foldingRange/refresh method (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1309">#1309</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/a57d7f12ae37e66f6c56297eab1d12a3a4ccf92c"><code>a57d7f1</code></a> Patch console methods if --stdio is used (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1301">#1301</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/b6e99d84cb024057b4cee0b724f1017a3325a7f9"><code>b6e99d8</code></a> Add <code>MessageType.Debug</code> (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1264">#1264</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/fb0a3d48b9aa1c52d527f623164b0b4f11115d5a"><code>fb0a3d4</code></a> Move to lock file version 3 (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1304">#1304</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/bf4395554d6fbed6d3e2da0bdddac6c28310632e"><code>bf43955</code></a> Merge new next release into main (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1303">#1303</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/f2ff7d55464a1f58f978cb6635bd8865f050553c"><code>f2ff7d5</code></a> Update dependencies (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/server/issues/1271">#1271</a>)</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/vscode-languageserver-node/commits/release/client/9.0.1/server">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~vscode-bot">vscode-bot</a>, a new releaser for vscode-languageserver since your current version.</p> </details> <br /> Updates `vscode-languageserver-protocol` from 3.15.3 to 3.17.5 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4f782ceac1b4444d335a32561bda0ded305c401e"><code>4f782ce</code></a> New release 3.17.5</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/d33ec0fce0bec8addd208651f28c2b96fe065d44"><code>d33ec0f</code></a> Update meta model (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1325">#1325</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/28b72114df3d11864240a2c30eb581c68c4a674a"><code>28b7211</code></a> Type scopeUri as URI (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1324">#1324</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/8c81fc842c98059d705cb917b1ecca38ecbfb8e5"><code>8c81fc8</code></a> Update lock files (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1323">#1323</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/300fac4c24ebf634760baa9eb0607b4c5b8a1b24"><code>300fac4</code></a> Prepare new release (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1322">#1322</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/4e057d5d6109eb3fcb075d0f99456f05910fda44"><code>4e057d5</code></a> Add the workspace/foldingRange/refresh method (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1309">#1309</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/b6e99d84cb024057b4cee0b724f1017a3325a7f9"><code>b6e99d8</code></a> Add <code>MessageType.Debug</code> (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1264">#1264</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/fb0a3d48b9aa1c52d527f623164b0b4f11115d5a"><code>fb0a3d4</code></a> Move to lock file version 3 (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1304">#1304</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/bf4395554d6fbed6d3e2da0bdddac6c28310632e"><code>bf43955</code></a> Merge new next release into main (<a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1303">#1303</a>)</li> <li><a href="https://github.com/microsoft/vscode-languageserver-node/commit/7792b0b21c994cc9bebc3117eeb652a22e2d9e1f"><code>7792b0b</code></a> Fixes <a href="https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol/issues/1293">#1293</a>: metamodel documentation strings contains unmatched back-ticks (#...</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/vscode-languageserver-node/commits/release/types/3.17.5/protocol">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~vscode-bot">vscode-bot</a>, a new releaser for vscode-languageserver-protocol since your current version.</p> </details> <br /> You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Co-authored-by: Roger Zhang <ruojiazh@amazon.com> Co-authored-by: laileni <laileni@amazon.com>
#8261) ## Problem - Connect button only appeared for spaces with remote access enabled. When users landed on the toolkit and saw running spaces without remote access, there was no connect button visible. This created confusion because: -- Users expected to be able to connect to any running space -- No visual indication that connection was possible -- Users didn't understand why some spaces were "connectable" and others weren't ## Solution - Always show connect button for all spaces (running and stopped, regardless of remote access status). When users click connect on a space without remote access, show clear dialog explaining what needs to happen and get their consent upfront. - There is no breaking change. - Tested for all use-cases SM-AI and SMUS ## Current User Exp --- https://github.com/user-attachments/assets/9c5c8634-42df-4cd1-988b-12cc8008d69e - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem We need a new parameter to differentiate implicit and explicit reject for inline ## Solution Include reason for inline notification --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
- Add CloudFormation Language Server Protocol support with multiple provider options - Include CloudFormation explorer with stack, resource, and change set management - Add stack deployment, validation, and change set workflows with S3 upload support - Include drift detection and diff visualization capabilities - Add CloudFormation environment and project management with cfn-init integration - Include telemetry and authentication handling - Add comprehensive test coverage for all CloudFormation features - Update package configurations and language syntax highlighting
## Problem This merges the released changes for rc-20251106 into main. MCM-137924316 ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
…pe (#8276) ## Problem - Fixes crash when connecting to spaces that have been stopped for long - The code was incorrectly accessing node.spaceApp.App.AppType, but the App object is undefined for spaces stopped for long as it deletes the App resource . This caused below error ``` Error running command aws.smus.openRemoteConnection: Remote connection failed: Cannot read properties of undefined (reading 'AppType'). This is likely caused by the extension that contributes aws.smus.openRemoteConnection. ``` ## Solution Changed to use node.spaceApp.SpaceSettingsSummary.AppType instead, which - - Is always available (part of space configuration, not runtime state) - Contains the correct AppType value needed for start/stop operations - SpaceSettingsSummary comes from ListSpaces API call and it will always returns SpaceSettingsSummary as part of the SpaceDetails. - AppType is a required field in SpaceSettingsSummary because every SageMaker space must have an application type (JupyterLab or CodeEditor). --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ents - Remove resource type from list using right click - Few startup fixes for CloudFormation extension - Add exec permissions and support node versions - Add node to AWS Explorer CFN panel - Add prompt for deploymentMode and plumb to deployment - Coordinate stack views and add overview to CFN console - Fix extract to parameter cursor command
feat(auth): align text patterns and verify profile after command succeeded
## Problem ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: Keen Wilson <40321520+keenwilson@users.noreply.github.com> Co-authored-by: Aseem sharma <198968351+aseemxs@users.noreply.github.com>
## Problem Fixes #8372. Currently, a deploy done using the lambda client will create a new published version of the function without any customer input. This is an issue because a) it is not the expected action for a deploy and b) version creation can take a long time and be expensive for Lambda Managed Instances customers. The cases in which this happened were: 1. Quick deploy through either the popup or the toolkit explorer 2. Direct upload where the user clicks on the node and selects the upload action 3. Remote invoke hot reloading, which will auto deploy code changes. Open to reasons to keep this, but I think that versioning isn't necessary in those cases and can end up being confusing. The original PR that added this was in 2020 (#1269), and based on that PR it seems like the original implementer was testing things out. ## Solution Remove the `Publish: true` field from the `UpdateFunctionCodeCommand`. Now, all deploys are simply updating the code. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com>
#8414) …nt stale data ## Problem - stack views did not render automatically after visibility change ## Solution - render stack views --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…redential refresh flow (#8432) ## Problem - Users were blocked when AWS CLI prompted to overwrite an existing console session, with no way to respond from VS Code - Credential refresh flow caused hanging "Getting credentials for profile" progress messages - Extension activation failed with "non-passive metric emitted at startup" error ## Solution <img width="474" height="181" alt="overwrite" src="https://github.com/user-attachments/assets/de836ee0-4821-4b79-9c69-4aa6168974ac" /> - Detect CLI overwrite prompts and show interactive dialog with exact CLI message - Send user's response ("y" or "n") to CLI stdin to proceed or cancel - Invalidate cached credentials after successful login and update connection state without triggering immediate credential fetch - Change telemetry emission from `.run()` to `.emit()` to comply with passive telemetry rules ## Testing - Fresh profile creation - Profile overwrite with user confirmation - User cancellation of overwrite - Credential refresh when session expires --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
fix(auth): Add console session profile overwrite prompt and improve credential refresh flow
…8413) ## Problem The hash algorithm using used to verify downloads is not configurable, make it configurable but default to `sha384` ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…in webview (#8418) ## Problem - Cx will begin to get used to the new console grouping stack events by operation id and expect the same in the IDE ## Solution - group stack events by operation id similar to console --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem - Hook invocations not visible in stack events ## Solution - show Hook invocations when there is a failure caused by Hook (last column is new and shows conditionally) <img width="1213" height="582" alt="image" src="https://github.com/user-attachments/assets/0e57407d-5fcc-415b-ae2a-e9e39d8d49dc" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
build(amazonq): merge release candidate version rc-20251218
…8438) ## Problem - Signing out did not clear the DZ client, so when user re-tries signing in with corrected region, they cannot access the targeted domain. ## Solution - Dispose smuAuthProvider when signing out, within authProvider dispose, the DZ clients will also be disposed --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem
- sometimes custom metrics are missing from `smus_stopSpace` and
`smus_openRemoteConnection`
## Solution
- Some telemetry custom variables are fetched via async calls
- This calls should gracefully handle async failures, and still being
able to record what metrics are available.
### Example
- successful async calls
```
2025-12-29 11:38:25.994 [debug] telemetry: smus_openRemoteConnection {
Metadata: {
metricId: 'acc0a9b4-e642-4e4f-a2a7-949879fca73d',
traceId: '911f58fd-9f63-4a8f-8e87-590d3f46d534',
smusAuthMode: 'iam',
smusSpaceKey: 'd-5eomwrxzxbim__default-ce003678-576c-4253-a65f-01ef29af4f94',
smusDomainRegion: 'us-east-2',
smusDomainId: 'dzd-byubiyc1bebgfd',
smusProjectId: 'b236u0pytkd02x',
smusDomainAccountId: '619071339486',
smusProjectAccountId: '619071339486',
smusProjectRegion: 'us-east-2',
duration: '20598',
result: 'Succeeded',
awsAccount: 'not-set',
awsRegion: 'us-west-2'
},
Value: 1,
Unit: 'None',
Passive: false
}
```
```
2025-12-29 11:39:28.454 [debug] telemetry: smus_stopSpace {
Metadata: {
metricId: '743e4212-8d6f-40bf-b2aa-a3ab45b5aa86',
traceId: '6bfd857d-cf53-410e-9e38-d1f8b37ec833',
smusAuthMode: 'iam',
smusSpaceKey: 'd-5eomwrxzxbim__default-ce003678-576c-4253-a65f-01ef29af4f94',
smusDomainRegion: 'us-east-2',
smusDomainId: 'dzd-byubiyc1bebgfd',
smusProjectId: 'b236u0pytkd02x',
smusDomainAccountId: '619071339486',
smusProjectAccountId: '619071339486',
smusProjectRegion: 'us-east-2',
duration: '4430',
result: 'Succeeded',
awsAccount: 'not-set',
awsRegion: 'us-west-2'
},
Value: 1,
Unit: 'None',
Passive: false
}
```
- failed async calls
```
2025-12-29 12:00:12.444 [warning] smus: Failed to get project region for telemetry: The security token included in the request is expired
```
```
2025-12-29 12:00:15.237 [debug] telemetry: smus_stopSpace {
Metadata: {
metricId: '52e34dd6-3016-4abc-82cb-2605c2cb7e71',
traceId: '8288d8a9-6674-4402-901a-0ebafe57ad1d',
smusAuthMode: 'iam',
smusSpaceKey: 'd-5eomwrxzxbim__default-ce003678-576c-4253-a65f-01ef29af4f94',
smusDomainRegion: 'us-east-2',
smusDomainId: 'dzd-byubiyc1bebgfd',
smusProjectId: 'b236u0pytkd02x',
smusDomainAccountId: '619071339486',
smusProjectAccountId: '619071339486',
smusProjectRegion: 'not-set',
duration: '2973',
result: 'Failed',
reason: 'ExpiredTokenException',
reasonDesc: 'ExpiredTokenException: Failed to stop space default-ce003678-576c-4253-a65f-01ef29af4f94: The security token included in the request is expired | ExpiredTokenException: The security token included in the request is expired',
awsAccount: 'not-set',
awsRegion: 'us-west-2'
},
Value: 1,
Unit: 'None',
Passive: false
}
```
`smusProjectRegion` is set to 'not-set` and the rest of custom metrics
are recorded.
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Co-authored-by: kzr-at-amazon <build@amazon.com>
## Problem On Windows, sometimes files cannot be deleted due to `EBUSY` errors. ## Solution Wrap all temporary file delete logic with a try-catch, and continue the transformation in case of any errors, because deleting the files is not strictly necessary. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: David Hasani <davhasan@amazon.com>
…will not be rendered (#8470) ## Problem ## Solution ``` 2025-12-29 01:20:24.853 [info] inline: found non null next token; Start pagination 2025-12-29 01:20:24.853 [info] GenerateCompletion activity: - number of suggestions: 1 - sessionId: 584db06a-4e51-4fbf-9656-6ac590756627 - first suggestion content (next line): // a function to find the square of a number public static int square(int a) { return a * a; } - duration between trigger to before sending LSP call: 0ms - duration between trigger to after receiving LSP response: 758ms - duration between before sending LSP call to after receving LSP response: 758ms - duration between trigger to completion suggestion is displayed: 759ms 2025-12-29 01:20:25.145 [info] inline: Pagination call is complete page 0 has 1 suggestions page 1 has 1 suggestions 2025-12-29 01:20:25.160 [info] inline: Done pagination; ShouldUpdate=true; updatedSuggestionCount=2 ``` --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
This merges the released changes for rc-20260108 into main. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
…edentials (#8500) ## Problem AWS CLI update process enters an infinite retry loop when outdated CLI is detected (exit code 252), causing continuous failed authentication attempts and poor user experience. ## Solution #### CLI update loop - affects users with outdated CLI - Remove automatic retry loop for AWS CLI updates to prevent infinite recursion - Show warning message when CLI update is attempted, requiring retry - Remove try-catch wrapper: it was swallowing errors and allowing profile activation to proceed despite failed CLI execution, causing invalid credential state <img width="1196" height="798" alt="1-need-update" src="https://github.com/user-attachments/assets/94a038bd-4972-4202-a940-e7b16348f465" /> <img width="1198" height="798" alt="2-run-installer" src="https://github.com/user-attachments/assets/343d8ad9-2fe2-4581-bbd9-68b063340441" /> <img width="1196" height="798" alt="3-install-successful" src="https://github.com/user-attachments/assets/5bfdf0af-44bf-4559-8a84-672f25851827" /> <img width="476" height="149" alt="4-warning-to-retry" src="https://github.com/user-attachments/assets/22d1e5dd-bd29-400a-b8ce-504e5acf1cf6" /> #### Testing: - Tested AWS CLI update scenario (exit code 252) with single update attempt and manual retry - Confirmed no infinite loops during installation --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
# Summary This PR migrates the SQLWorkbench custom API client from the deprecated AWS SDK v2 generator pattern to standalone AWS SDK v3-compatible packages. This migration is required as part of the broader AWS Toolkit repository migration from SDK v2 to v3. # Problem The AWS Toolkit VSCode repository is deprecating the centralized generateServiceClient.ts script that generates TypeScript clients from service JSON definitions. The SageMaker Unified Studio (SMUS) team currently uses this v2 generator for SQLWorkbench. # Solution * Created standalone package @amzn/sql-workbench-client * Updated imports to use new standalone package * Migrated from SDK v2 .promise() pattern to SDK v3 Command pattern (client.send(command)) * Updated credential handling to use credential provider function for auto-refresh support * Replaced local type definitions with SDK-provided types (DatabaseConnectionConfiguration, ParentResource, Resource, etc.) * Removed dependency for SQLWorkbench on the deprecated generateServiceClient.ts script * Updated unit tests to mock SDK v3 send method instead of v2 .promise() pattern --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com>
…8490) ## Description This PR fixes a bug where space status was incorrectly displayed for spaces with mixed-case names. ## Problem The SageMaker ListApps API's SpaceNameEquals filter is case-sensitive, but space names in SMUS (SageMaker Unified Studio) can have mixed case. When a space name contained uppercase characters, the API would not find the matching app, causing incorrect status display in the UI. ## Solution Added listAppsForDomainMatchSpaceIgnoreCase method with an optimization: If the space name is all lowercase, uses the efficient listAppForSpace method with SpaceNameEquals filter (server-side filtering) Otherwise, fetches all apps via listAppsForDomain and performs case-insensitive client-side matching ## Changes * packages/core/src/shared/clients/sagemaker.ts: Added listAppsForDomainMatchSpaceIgnoreCase method * packages/core/src/awsService/sagemaker/sagemakerSpace.ts: Updated updateSpaceAppStatus() to use the new method ## Technical Notes: Why Batch Polling Optimization Was Not Implemented Goal: Since listAppsForDomainMatchSpaceIgnoreCase fetches all apps in a domain (for case-insensitive matching), ideally we could reuse this single API response to update multiple spaces in the same domain simultaneously, reducing redundant API calls during polling. Why It's Difficult: Per-Space Update Architecture: The current updateSpaceAppStatus() method is designed to update a single space. It's called individually for each space by the PollingSet timer. Shared Method for Different Use Cases: The same updateSpaceAppStatus() method serves two purposes: Initial status refresh: Triggered by user action (e.g., clicking "Connect"). Requires real-time data to correctly determine if the space should be added to the polling set. Periodic polling updates: Triggered by PollingSet timer. Could potentially use shared/batched data. Real-time Data Requirement: When a user triggers an action, the initial refresh must return real-time data. If the status is stale, the space might not be added to the polling set, causing the UI to not update properly after user actions. Refactoring Scope: To properly implement batch updates, we would need to separate the initial refresh logic from polling update logic, which is a significant architectural change beyond the scope of this bug fix. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com>
## Problem - When user connects to space, it creates a duplicate window for the same space ## Solution - Assign unique identifier to workspace. This will open same external window when connecting to same workspace. ## Notes - Test cases added in separate pr with unit tests - Retested locally for most recent changes with new vsix --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
# Summary This PR migrates the DataZone custom API client from the deprecated AWS SDK v2 generator pattern to standalone AWS SDK v3-compatible packages. This migration is required as part of the broader AWS Toolkit repository migration from SDK v2 to v3. The AWS Toolkit VSCode repository is deprecating the centralized generateServiceClient.ts script that generates TypeScript clients from service JSON definitions. The SageMaker Unified Studio (SMUS) team currently uses this v2 generator for DataZone Custom API. # Solution * Created standalone package @amzn/datazone-custom-client with SDK v3 patterns * Updated DataZoneCustomClientHelper to use SDK v3 client initialization and Command pattern * Migrated from client.methodName().promise() to client.send(new Command()) pattern * Updated credential provider to use SDK v3 async credential provider function * Updated imports to use new standalone package types and commands * Updated test files to mock SDK v3 send() method instead of v2 .promise() pattern * Removed dependency for DataZone Custom API on the deprecated generateServiceClient.ts script --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com>
This merges the released changes for rc-20260115 into main. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
## Problem - workspace connection is currently failing via presigned url due to change of attributes ## Solution - reverting change and using eks cluster attr for hostname ## Testing - updated unit tests - tested locally with new vsix --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…#8514) ## Problem Console session credentials fail to work properly in two scenarios: 1. After token refresh or profile overwrite: Users encounter "Your session has expired" errors even after successfully running aws login, requiring manual VS Code restart without clear guidance (reported in #8488) 2. Immediate connection use after CLI login: When users try to use a connection immediately after aws login completes, the credential provider was created before the CLI wrote the new login session to disk, causing authentication failures ## Solution - Enhanced makeConsoleSessionCredentialsProvider() to detect stale credential scenarios and prompt for window reload <img width="1409" height="939" alt="final-2-after-succeeds" src="https://github.com/user-attachments/assets/2c0b77be-ea10-4a41-9642-29d637a03110" /> - Added user-friendly messages showing identity ARN after successful login <img width="1408" height="941" alt="final-1-before-retry" src="https://github.com/user-attachments/assets/841721be-525d-4853-8d7a-b49f7d97c272" /> - Improved inline documentation explaining AWS CLI vs SDK credential handling differences - Added handling for does not contain login_session error when provider is created too early - Removed try-catch wrapper when verifying that connection exists after CLI succeeds ## Tradeoffs Reloading the VS Code window is a heavier UX, but it is the only deterministic way to fully reinitialize credential providers and avoid using stale credentials. Reloading guarantees that all in0memory credential providers, Auth state, and AWS SDK clients are fully reinitialized. This avoids subtle, hard-to-debug states where credentials appear refreshed on disk but stale credentials are still used at runtime. The reload is user-initiated via confirmation, not automatic. For future direction, this needs a supported Auth/provider reset mechanism to refresh credentials without requiring a window reload. ## Testing 1. Run `npm run compile` to verify build. 2. Run `npm run package`. Manual verification of end-to-end flow - Verified token refresh flow prompts for reload and works after reload - Tested immediate connection use after aws login triggers appropriate reload prompt - Confirmed profile overwrite scenarios handle credential refresh correctly --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem - This setting is no longer used. <img width="1276" height="242" alt="image" src="https://github.com/user-attachments/assets/71c2a761-e849-4058-ac99-41329cd32c28" /> ## Solution - Removing /dev amazonq settings --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
This merges the released changes for rc-20260122 into main. MCM-XXX --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic merge failed
Command line hint
To perform the merge from the command line, you could do something like the following (where "origin" is the name of the remote in your local git repo):