Skip to content

fix(amazonq): Enabling fix all feature for warning and removing limit on amount of issues to be fixed #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
laileni-aws wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(amazonq): Enabling fix all feature for warning and removing limit on amount of issues to be fixed #8516

laileni-aws wants to merge 1 commit into from
+6 −9

Conversation

@laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Jan 21, 2026 •
edited
Loading

Problem

  • Today we have a limit on number issues we send to LLM as part of Amazon Q: Fix all Errors feature in Amazon Q.
  • Amazon Q: Fix all Errors feature does not work on warning issues.

Solution

  • Fixed above issues.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws requested a review from a team as a code owner January 21, 2026 00:11
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

ashishrp-aws
ashishrp-aws reviewed Jan 21, 2026
View reviewed changes
packages/amazonq/src/lsp/chat/autoDebug/controller.ts
*/
private filterErrorDiagnostics(diagnostics: vscode.Diagnostic[]): vscode.Diagnostic[] {
return diagnostics.filter((d) => {
if (d.severity !== vscode.DiagnosticSeverity.Error) {
Copy link
Contributor

@ashishrp-aws ashishrp-aws Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait can we keep this? why are we entertaining all kinds of diagnostic issues? wouldn't it be better to check only for errors?

Copy link
Contributor Author

@laileni-aws laileni-aws Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this should be for errors?

Copy link
Contributor

@ashishrp-aws ashishrp-aws Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to provide fix only for diagnostic errors but not the other kind? unless we want it to open up for everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashishrp-aws ashishrp-aws Awaiting requested review from ashishrp-aws

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laileni-aws @ashishrp-aws