Skip to content

fix(terraform_plan): fix CloudStorageSelfLogging for buckets without logging #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffreytolar wants to merge 1 commit into
base: main
Choose a base branch
from
+545 −1
Open

fix(terraform_plan): fix CloudStorageSelfLogging for buckets without logging #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checkov/terraform/checks/resource/gcp/CloudStorageSelfLogging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def scan_resource_conf(self, conf: Dict[str, Any]) -> CheckResult:
if log_bucket_name != bucket_name:
return CheckResult.PASSED
return CheckResult.FAILED
return CheckResult.FAILED
return CheckResult.PASSED
Copy link
Author

@jeffreytolar jeffreytolar Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure in what other cases conf["logging"][0] would be empty. This appears to date back to the initial introduction of this resource way back in #878.

From the test plan, the "logging": [] gets translated to conf["logging"] = [[]], i.e., an array containing an empty array.

return CheckResult.UNKNOWN


Expand Down
Loading
Loading