2923 zoominfo

[marijahorvat171]

API can be used only with paid account; component not tested

[monikakuster]

Consider using Body.of(Object... keyValueArray) or Body.of(String name, Object[] keyValueArray), as these may handle nulls more gracefully.

Please review all your perform methods: when using Map.of(key1, value1, ...), if any key or value is null, it will throw a NullPointerException.

For example, if inputParameters.getList(OUTPUT_FIELDS) or inputParameters.getString(COMPANY_NAME) returns null, the current implementation will fail at runtime.

Update the map creation logic to safely handle possible null values and avoid NPEs.

[monikakuster]

This change still does not fully address the issue.

Please review the implementation of Body.of(Object... keyValueArray) and Body.of(String name, Object[] keyValueArray): these methods only add entries where both the key and value are non-null, and they require an even number of elements.

Simply replacing Map.of(...) with object arrays does not guarantee correct structure or adherence to the API specification—especially when the API expects nested maps (e.g., for matchCompanyInput).

To avoid NullPointerException and ensure your payload matches the API documentation, you should manually construct each map, including only those entries whose values are not null. This approach both prevents runtime errors and ensures the request body structure is valid for the API.

[monikakuster]

Please review the tests for this component and compare them with tests for previously implemented components.

[monikakuster]

@marijahorvat171 tests are still not improved

[monikakuster]

This change still does not fully address the issue.

Please review the implementation of Body.of(Object... keyValueArray) and Body.of(String name, Object[] keyValueArray): these methods only add entries where both the key and value are non-null, and they require an even number of elements.

Simply replacing Map.of(...) with object arrays does not guarantee correct structure or adherence to the API specification—especially when the API expects nested maps (e.g., for matchCompanyInput).

To avoid NullPointerException and ensure your payload matches the API documentation, you should manually construct each map, including only those entries whose values are not null. This approach both prevents runtime errors and ensures the request body structure is valid for the API.

[sonarqubecloud]

Quality Gate passed for 'server'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud