2445 Replace unit with integration tests #3948
Merged
+2,291
−1,482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces unit tests with integration tests for GraphQL controllers in the MCP (Model Context Protocol) modules. The PR introduces proper GraphQL slice testing using Spring's @GraphQlTest annotation, replacing the previous unit tests that used @ExtendWith(MockitoExtension.class). Additionally, it includes a production code fix to handle null parameters in the McpToolGraphQlController.
Changes:
- Replaced 6 unit test classes with 6 integration test classes using
@GraphQlTest - Added test configuration classes with mock bean definitions and GraphQL scalar type implementations
- Created test-specific GraphQL schema files for integration testing
- Fixed null-safety issue in
McpToolGraphQlController.createMcpTool()method - Added test dependency for app-config module
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test.graphqls (platform-mcp) | Test-only GraphQL schema with minimal type stubs for platform MCP tests |
| test.graphqls (automation-mcp) | Complete test schema with all types, queries, and mutations for automation MCP tests |
| McpGraphQlTestConfiguration.java | Test configuration providing mocked beans and GraphQL scalar types for platform MCP |
| AutomationMcpGraphQlTestConfiguration.java | Test configuration providing mocked beans and GraphQL scalar types for automation MCP |
| McpGraphQlConfigurationSharedMocks.java | Annotation consolidating common @MockitoBean declarations for platform MCP tests |
| AutomationMcpGraphQlConfigurationSharedMocks.java | Annotation consolidating common @MockitoBean declarations for automation MCP tests |
| *IntTest.java (6 files) | New integration tests using GraphQlTester for end-to-end GraphQL testing |
| *Test.java (6 deleted files) | Removed unit tests that tested controllers in isolation with mocked services |
| McpToolGraphQlController.java | Added null-safety check for optional parameters field in createMcpTool mutation |
| build.gradle.kts | Added test dependency for app-config module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../src/test/java/com/bytechef/platform/mcp/web/graphql/config/McpGraphQlTestConfiguration.java
Outdated
Show resolved
Hide resolved
...va/com/bytechef/automation/mcp/web/graphql/config/AutomationMcpGraphQlTestConfiguration.java
Outdated
Show resolved
Hide resolved
…gic to `GraphQLScalarTypes` utility class and updating imports
|
ivicac
force-pushed
the
2445_1
branch
2 times, most recently
from
e71d9f9 to
d773845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.