Skip to content

Conversation

@ivicac
Copy link
Contributor

@ivicac ivicac commented Jan 21, 2026

  • 3894 client - Update WorkflowNodeDetailsPanel to support variableOutputResponse when retrieving output schema
  • 3894 client - client - Add unit tests for getOutputSchemaFromWorkflowNodeOutput to validate output schema resolution logic

@ivicac ivicac changed the title 3894 3894 client - Update WorkflowNodeDetailsPanel to support variableOutputResponse when retrieving output schema Jan 21, 2026
@ivicac ivicac requested a review from Copilot January 21, 2026 04:40
@ivicac ivicac linked an issue Jan 21, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the workflow node output schema resolution by introducing support for variableOutputResponse as a fallback when outputResponse is not available. This is particularly important for loop task dispatchers that provide variable properties (item, index) via variableOutputResponse.

Changes:

  • Created a new utility function getOutputSchemaFromWorkflowNodeOutput to handle output schema resolution with fallback logic
  • Added comprehensive unit tests covering all edge cases and scenarios
  • Updated WorkflowNodeDetailsPanel to use the new utility function instead of directly accessing outputResponse?.outputSchema

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
client/src/pages/platform/workflow-editor/utils/getOutputSchemaFromWorkflowNodeOutput.ts New utility function that retrieves output schema from either outputResponse or variableOutputResponse with proper fallback logic
client/src/pages/platform/workflow-editor/utils/getOutputSchemaFromWorkflowNodeOutput.test.ts Comprehensive unit tests covering all scenarios including undefined inputs, fallback behavior, and loop task dispatcher cases
client/src/pages/platform/workflow-editor/components/WorkflowNodeDetailsPanel.tsx Updated to use the new utility function for retrieving output schema instead of inline property access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from kresimir-coko January 21, 2026 04:43
ivicac and others added 3 commits January 22, 2026 06:05
…utputResponse` when retrieving output schema
…wNodeOutput` to validate output schema resolution logic
…deOutput

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'client'

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data Pill popup dialog does not show loop items

3 participants