Skip to content

Fix memory leak in GC when rootset enumeration fails #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lum1n0us merged 1 commit into from
Jan 26, 2026
Merged

Fix memory leak in GC when rootset enumeration fails #4793

lum1n0us merged 1 commit into from
Jan 26, 2026
+5 −1

Conversation

@kylo5aby
Copy link
Contributor

@kylo5aby kylo5aby commented Jan 19, 2026

When gct_vm_begin_rootset_enumeration returns failure, the mark_node
allocated during the enumeration process was not being freed, causing
a memory leak.

Fix by calling rollback_mark() to release any allocated mark_node
before returning GC_ERROR.

@kylo5aby kylo5aby requested a review from no1wudi as a code owner January 20, 2026 06:25
@lum1n0us lum1n0us added the bug-fix Determine if this PR addresses a bug. It will be used by scripts to classify PRs. label Jan 23, 2026
@lum1n0us lum1n0us merged commit 09a2456 into bytecodealliance:main Jan 26, 2026
504 checks passed
@kylo5aby kylo5aby deleted the gc branch January 30, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lum1n0us lum1n0us lum1n0us approved these changes

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi

Assignees

No one assigned

Labels

bug-fix Determine if this PR addresses a bug. It will be used by scripts to classify PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylo5aby @lum1n0us