Skip to content

chore(code-conversion): fix sb code-examples#1034

Merged
venetrius merged 5 commits intomainfrom
540-add-examples
Feb 26, 2026
Merged

chore(code-conversion): fix sb code-examples#1034
venetrius merged 5 commits intomainfrom
540-add-examples

Conversation

@venetrius
Copy link
Member

@venetrius venetrius commented Feb 24, 2026

Pull Request Template

Description

#540

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Test-only changes (no production code changes)

Testing Checklist

Black-Box Testing Requirements

  • Tests follow black-box testing approach: verify behavior through observable outputs (logs, C8 API queries, real-world skip scenarios)
  • Tests DO NOT access implementation details (DbClient, IdKeyMapper, ..impl.. packages except logging constants)
  • Architecture tests pass (ArchitectureTest validates these rules)

Test Coverage

  • Added tests for new functionality
  • Updated tests for modified functionality
  • All tests pass locally

Architecture Compliance

Run architecture tests to ensure compliance:

mvn test -Dtest=ArchitectureTest

If architecture tests fail, refactor your tests to use:

  • LogCapturer for log assertions
  • camundaClient.new*SearchRequest() for C8 queries
  • Real-World skip scenarios (e.g., migrate children without parents)

Documentation

  • Updated TESTING_GUIDELINES.md if adding new test patterns
  • Added Javadoc comments for public APIs
  • Updated README if user-facing changes

Checklist

  • Code follows project style guidelines
  • Self-reviewed the code
  • Added comments for complex logic
  • No new compiler warnings
  • Dependent changes have been merged

Related Issues

#540

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds execution listener migration example code to both Camunda 7 and Camunda 8 code-examples modules, and fixes configuration issues in the Camunda 8 Spring Boot example project. The changes demonstrate how Camunda 7 execution listeners migrate to Camunda 8 JobWorkers, providing a complete working example with tests and REST endpoints.

Changes:

  • Added execution listener example files for both Camunda 7 and Camunda 8 (BPMN, Java implementation, controller, tests)
  • Fixed Camunda 8 example to use spring-boot-starter-web instead of spring-boot-starter (required for REST controllers)
  • Added missing test scope to camunda-process-test-spring dependency
  • Renamed Camunda 7 external task worker subscriptions to unique names to prevent conflicts
  • Deleted unnecessary Maven wrapper configuration from camunda-8 example module
  • Added Camunda 7 external task client configuration in application.yaml

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
code-conversion/patterns/code-examples/camunda-8/pom.xml Changed to spring-boot-starter-web and added test scope to camunda-process-test-spring
code-conversion/patterns/code-examples/camunda-8/src/main/java/io/camunda/conversion/ProcessPaymentsApplication.java Added @Deployment annotation to auto-deploy BPMN files
code-conversion/patterns/code-examples/camunda-8/src/main/java/io/camunda/conversion/execution_listeners/MyExecutionListener.java JobWorker implementation showing migrated execution listener
code-conversion/patterns/code-examples/camunda-8/src/main/java/io/camunda/conversion/execution_listeners/ExecutionListenerTestController.java REST endpoint to trigger the execution listener test process
code-conversion/patterns/code-examples/camunda-8/src/main/resources/execution-listener-test.bpmn BPMN process with service task that invokes JobWorker
code-conversion/patterns/code-examples/camunda-8/src/test/java/io/camunda/conversion/execution_listeners/MyExecutionListenerTest.java Integration test verifying the migrated execution listener works
code-conversion/patterns/code-examples/camunda-8/src/test/resources/application.properties Test configuration file for Spring Boot tests
code-conversion/patterns/code-examples/camunda-8/.mvn/wrapper/maven-wrapper.properties Deleted unnecessary Maven wrapper configuration
code-conversion/patterns/code-examples/camunda-7/src/main/java/org/camunda/conversion/execution_listeners/MyExecutionListener.java Original Camunda 7 execution listener implementation
code-conversion/patterns/code-examples/camunda-7/src/main/java/org/camunda/conversion/execution_listeners/ExecutionListenerTestController.java REST endpoint for Camunda 7 version
code-conversion/patterns/code-examples/camunda-7/src/main/resources/execution-listener-test.bpmn BPMN process with execution listener
code-conversion/patterns/code-examples/camunda-7/src/main/resources/application.yaml Added external task client configuration
code-conversion/patterns/code-examples/camunda-7/src/main/java/org/camunda/conversion/external_task_workers//.java Renamed external task subscriptions to unique names to prevent conflicts

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we want to delete mvnw* in camunda-8 directory too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Maybe move dependencyManagement section before dependencies, the pom is a bit chaotic at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Cleaned up the pom.xml file.

@venetrius venetrius merged commit 84ff0b6 into main Feb 26, 2026
26 checks passed
@venetrius venetrius deleted the 540-add-examples branch February 26, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants