Skip to content

Add coverage config #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrnr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add coverage config #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b96da7
Add coverage config
cbrnr Jan 16, 2025
09e94ed
Try different arg
cbrnr Jan 16, 2025
803baf6
Remove unused settings
cbrnr Jan 16, 2025
ae1c480
Use correct location
cbrnr Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .coveragerc
View file
Open in desktop

This file was deleted.

10 changes: 8 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ dev = [ # everything needed for development
"mypy >= 0.991",
"pre-commit >= 2.13.0",
"pytest >= 6.2.0",
"pytest-cov >= 6.0.0",
"ruff >= 0.4.0",
"setuptools >= 56.0.0",
]
Expand Down Expand Up @@ -85,7 +86,7 @@ build = "cp39-*" # abi3
select = "*"
inherit.repair-wheel-command = "append"
repair-wheel-command = [
"pipx run abi3audit --strict --report {wheel}",
"pipx run abi3audit --strict --report {wheel}",
]

[tool.cibuildwheel.linux]
Expand All @@ -99,9 +100,13 @@ archs = "x86_64 arm64"
archs = "AMD64"
before-build = "pip install delvewheel"
repair-wheel-command = [
"delvewheel repair -w {dest_dir} {wheel}",
"delvewheel repair -w {dest_dir} {wheel}",
]

[tool.coverage.run]
branch = true
source = ["src/sleepecg"]

[tool.mypy]
ignore_missing_imports = true
disallow_untyped_defs = true
Expand All @@ -116,6 +121,7 @@ filterwarnings = [
'ignore:.*datetime.datetime.utcfromtimestamp\(\):DeprecationWarning',
'ignore:(?s).*Pyarrow:DeprecationWarning',
]
addopts = "--cov"
Copy link
Contributor

@larsoner larsoner Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at lost of tracebacks on CIs and locally I'd recommend a couple more options we have in MNE-Python

Suggested change
addopts = "--cov"
addopts = "--cov=sleepecg -rfEXs --cov-report= --tb=short"

some of which could then be removed from

sleepecg/.github/workflows/cibuildwheel.yml

Line 98 in 94e8390

- run: pytest -rfEXs --cov=sleepecg --cov-report=xml --tb=short --cov-branch --color=yes $PYTEST_EXTRA tests/


[tool.ruff]
line-length = 92
Expand Down
Loading