nvmeof: Add support for snapshots in the NVMe-oF driver#5928
Merged
mergify[bot] merged 2 commits intoceph:develfrom Jan 22, 2026
Merged
nvmeof: Add support for snapshots in the NVMe-oF driver#5928mergify[bot] merged 2 commits intoceph:develfrom
mergify[bot] merged 2 commits intoceph:develfrom
Conversation
Member
Author
|
Testing results:
|
nixpanic
force-pushed
the
nvmeof/snapshot
branch
from
709ec13 to
812d119
Compare
Snapshots are not visible in the NVMe-oF gateway, it would not know what to do with them anyway. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic
force-pushed
the
nvmeof/snapshot
branch
from
812d119 to
9bd257a
Compare
mergify
bot
dismissed stale reviews from gadididi and black-dragon74
Pull request has been modified.
gadididi
approved these changes
Jan 21, 2026
black-dragon74
approved these changes
Jan 21, 2026
Madhu-1
approved these changes
Jan 22, 2026
Collaborator
|
@Mergifyio queue |
Contributor
❌ The pull request has been removed from the queue
|
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 3 hours 50 minutes 26 seconds in the queue, including 16 minutes 6 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Member
Author
|
@Mergifyio requeue |
Contributor
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
Contributor
❌ The pull request has been removed from the queue
|
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 39 minutes 7 seconds in the queue, including 38 minutes 55 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Member
Author
|
e2e failed 2x already, but there are no nvmeof e2e tests... |
Member
Author
|
@Mergifyio requeue |
Contributor
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Contributor
Merge Queue Status✅ The pull request has been merged at 9bd257a This pull request spent 2 hours 32 minutes 1 second in the queue, including 2 hours 31 minutes 42 seconds running CI. Required conditions to merge
|
Contributor
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for snapshots in the NVMe-oF driver
CreateSnapshotandDeleteSnapshotCSI procedures to the RBD driverVolumeSnapshotClassChecklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)