Revert "rbd: fetch the volumeIds from VGRContent's status for omap data" #5962
+1
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Ladha
force-pushed
the
revert-vgrc-status
branch
from
0171692 to
cc587a9
Compare
Member
|
Please update the details in the commit message too. The description of the PR should include a path forward. Why not propose that downstream change here as well? |
Member
|
Does this need a backport to one or more release branches? |
Contributor
Author
The d/s change is not part of u/s yet, hence only reverting the change here. |
Contributor
Author
It has to be backport to |
This reverts commit e62e083. The commit needs to be reverted as on further testing it was found that fetching the omap data from status could mean that we would trigger a modify operation during promotion of a group which could lead to inconsistency. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Nikhil-Ladha
force-pushed
the
revert-vgrc-status
branch
from
cc587a9 to
2cd7076
Compare
Contributor
Author
Done. |
nixpanic
approved these changes
Jan 22, 2026
iPraveenParihar
approved these changes
Jan 22, 2026
Member
|
@Mergifyio queue |
Contributor
❌ The pull request has been removed from the queue
|
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 17 minutes 31 seconds in the queue, including 17 minutes 18 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Member
|
@Mergifyio requeue |
Contributor
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
Contributor
❌ The pull request has been removed from the queue
|
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 16 minutes 59 seconds in the queue, including 16 minutes 47 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Member
|
@Mergifyio requeue |
Contributor
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
Contributor
❌ The pull request has been removed from the queue
|
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 21 minutes 5 seconds in the queue, including 20 minutes 55 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
78 tasks
Member
|
#5968 addresses the CI issue. Please wait with re-queuing until that PR is merged. |
Contributor
Author
|
@Mergifyio requeue |
Contributor
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
Contributor
🟠 The pull request is queued to be mergedDetailsBranch devel (cba25cb) and #5962 are embarked together for merge. Required conditions of queue
Required conditions to stay in the queue:
|
Contributor
Merge Queue Status🟠 Waiting for merge conditions (rule: Entered the queue at: Required conditions to merge
Required conditions to stay in the queue
|
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit e62e083.
The commit needs to be reverted as on further testing it was found that fetching the omap data from status could mean that we would trigger a modify operation during promotion of a group which could lead to inconsistency.
A safer option to check the sanity of groups before modifying is added in the d/s PR: red-hat-storage#687 before attempting to modify the group.