Skip to content

ci: delay checking ci/skip/multi-arch-build label#5971

Merged
mergify[bot] merged 1 commit intoceph:develfrom
nixpanic:testing/multi-arch-check
Jan 28, 2026
Merged

ci: delay checking ci/skip/multi-arch-build label#5971
mergify[bot] merged 1 commit intoceph:develfrom
nixpanic:testing/multi-arch-check

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Jan 23, 2026

When a GitHub Event is created, the labels of the PR are set to the
current values. Mergify will only set the labels, or copy the labels to
the PR once the PR is created. That means the initial GitHub Event does
not have the right labels set yet.

In order to really skip the multi-arch-build, and run single-arch-build
instead, the label needs to be checked from the PR, instead of compared
from the labels in the GitHub Event.

@mergify mergify bot added the component/testing Additional test cases or CI work label Jan 23, 2026
@nixpanic nixpanic force-pushed the testing/multi-arch-check branch 6 times, most recently from 56a9064 to 7d7b337 Compare January 23, 2026 13:15
@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Jan 23, 2026
@nixpanic nixpanic force-pushed the testing/multi-arch-check branch 5 times, most recently from ab06a71 to 0fef12f Compare January 23, 2026 14:25
@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures and removed ci/skip/multi-arch-build skip building on multiple architectures labels Jan 23, 2026
@nixpanic nixpanic requested a review from a team January 23, 2026 14:29
@nixpanic nixpanic marked this pull request as ready for review January 23, 2026 14:29
@nixpanic
Copy link
Member Author

Tested a lot, and this seems to work now. See the attempts of the last runs at https://github.com/ceph/ceph-csi/actions/runs/21289467990/job/61279172064?pr=5971

@nixpanic nixpanic force-pushed the testing/multi-arch-check branch from 0fef12f to 3454814 Compare January 27, 2026 15:28
@nixpanic nixpanic marked this pull request as draft January 27, 2026 15:28
@nixpanic nixpanic force-pushed the testing/multi-arch-check branch 3 times, most recently from 0e2f093 to 3d64781 Compare January 27, 2026 15:42
When a GitHub Event is created, the labels of the PR are set to the
current values. Mergify will only set the labels, or copy the labels to
the PR once the PR is created. That means the initial GitHub Event does
not have the right labels set yet.

In order to really skip the multi-arch-build, and run single-arch-build
instead, the label needs to be checked from the PR, instead of compared
from the labels in the GitHub Event.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the testing/multi-arch-check branch from 3d64781 to 96ca63f Compare January 27, 2026 15:45
@nixpanic nixpanic added ci/skip/multi-arch-build skip building on multiple architectures and removed ci/skip/multi-arch-build skip building on multiple architectures labels Jan 27, 2026
@nixpanic nixpanic marked this pull request as ready for review January 27, 2026 15:50
@nixpanic nixpanic requested review from a team and black-dragon74 January 27, 2026 15:55
Copy link
Member

@black-dragon74 black-dragon74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot added the queued label Jan 28, 2026
mergify bot added a commit that referenced this pull request Jan 28, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026

Merge Queue Status

✅ The pull request has been merged at 96ca63f

This pull request spent 5 minutes 29 seconds in the queue, including 5 minutes 17 seconds running CI.
The checks were run on draft #5982.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of:
    • all of:
      • base=devel
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
      • any of:
        • label=ci/skip/e2e
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.32
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/k8s-e2e-external-storage/1.34
          • status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • status-success=ci/centos/mini-e2e/k8s-1.32
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.34
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
    • all of:
      • base~=^(release-.+)$
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
      • any of:
        • label=ci/skip/e2e
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.32
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/k8s-e2e-external-storage/1.34
          • status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • status-success=ci/centos/mini-e2e/k8s-1.32
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.34
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
    • all of:
      • base=release-v3.15
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
      • any of:
        • label=ci/skip/e2e
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.31
          • status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • status-success=ci/centos/mini-e2e/k8s-1.31
          • status-success=ci/centos/k8s-e2e-external-storage/1.32
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.32
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
    • all of:
      • base=ci/centos
      • status-success=ci/centos/jjb-validate
      • status-success=ci/centos/job-validation

@mergify mergify bot merged commit 8b9bc61 into ceph:devel Jan 28, 2026
21 of 23 checks passed
@mergify mergify bot removed the queued label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants