Revert "rbd: fetch the volumeIds from VGRContent's status for omap data" (backport #5962)#5972
Merged
mergify[bot] merged 1 commit intorelease-v3.16from Feb 3, 2026
Merged
Conversation
This reverts commit e62e083. The commit needs to be reverted as on further testing it was found that fetching the omap data from status could mean that we would trigger a modify operation during promotion of a group which could lead to inconsistency. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com> (cherry picked from commit 80c0474)
mergify
bot
added
ok-to-test
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
nixpanic
approved these changes
Jan 23, 2026
Nikhil-Ladha
approved these changes
Jan 27, 2026
Contributor
|
/test ci/centos/mini-e2e/k8s-1.34 |
Contributor
|
/test ci/centos/upgrade-tests-rbd |
78 tasks
Contributor
Author
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 2 hours 27 minutes 57 seconds in the queue, including 2 hours 27 minutes 47 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
Member
|
@Mergifyio requeue |
Contributor
Author
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Contributor
Author
Merge Queue Status✅ The pull request has been merged at c91235a This pull request spent 3 hours 37 minutes 10 seconds in the queue, including 3 hours 36 minutes 47 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts commit e62e083.
The commit needs to be reverted as on further testing it was found that fetching the omap data from status could mean that we would trigger a modify operation during promotion of a group which could lead to inconsistency.
A safer option to check the sanity of groups before modifying is added in the d/s PR: red-hat-storage#687 before attempting to modify the group.
This is an automatic backport of pull request #5962 done by Mergify.